Skip to content

Python: Correct skills sample setup environment variables - #9700

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
microsoft:mainfrom
BlueRaddish:fix/oct26a-mm-skills-setup-docs
Oct 27, 2026
Merged

Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
microsoft:mainfrom
BlueRaddish:fix/oct26a-mm-skills-setup-docs

Conversation

@BlueRaddish

Copy link
Copy Markdown
Contributor

Motivation & Context

The file-based and mixed skills guides tell users to set AZURE_OPENAI_MODEL, but both samples read FOUNDRY_MODEL. Following either guide with a custom deployment silently leaves the sample on gpt-4o-mini. The mixed skills guide also supplies an Azure OpenAI account URL where the sample needs a Foundry project endpoint.

Description & Review Guide

  • What are the major changes? Correct the model environment variable in both READMEs and use the canonical project-scoped Foundry endpoint placeholder in the mixed skills guide. Three documentation lines change.
  • What is the impact of these changes? The setup instructions match the unchanged samples and the existing consolidated environment-variable inventory.
  • What do you want reviewers to focus on? Running both complete, unchanged sample main() functions against a recording FoundryChatClient boundary reproduced two original custom-deployment failures and four passing controls. The corrected guides pass all six cases; the endpoint placeholder also satisfies the sample documentation convention. These checks stop before any agent or provider call and do not test live Foundry connectivity. The frozen all-workspace environment setup, ordinary scoped hooks, and normal native commit hooks passed, including the required whole-samples Ruff and Pyright checks. The resulting source commit was independently imported from its bundle against the pristine base and its exact three-line patch verified. The full unit suite and build were not run for this documentation-only change.

Related Issue

N/A - trivial change. These are obvious corrections to existing sample configuration names and the required project endpoint format. No runtime API or design decision changes.

AI Assistance

  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: OpenAI Codex assisted with diagnosis, the three documentation corrections, deterministic verification, and this description.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@agent-framework-automation agent-framework-automation Bot added documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs python Usage: [Issues, PRs], Target: Python labels Oct 26, 2026
@eavanvalkenburg

Copy link
Copy Markdown
Member

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): eb647fef2417
Model: gpt-5.6-sol

Overview

The documentation changes align both skills guides with the unchanged sample entry points and the FoundryChatClient environment contract. The mixed-skills endpoint also follows the repository's required project-scoped Foundry format, while existing client guards and tests confirm that the corrected values are forwarded or fail fast when absent. No publishable risk remains in the reviewed changes.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

Merged via the queue into microsoft:main with commit abaf33a Oct 27, 2026
54 of 58 checks passed

This branch was previously deployed

1 inactive deployment
github-app-auth — eb647fef Deployed Oct 26, 2026 by BlueRaddish via team_check #7453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants