Repository navigation
Python: Correct skills sample setup environment variables - #9700
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoOct 27, 2026
Conversation
AI-assisted with OpenAI Codex.
BlueRaddish
marked this pull request as ready for review
October 26, 2026 09:48
BlueRaddish
temporarily deployed
to
github-app-auth
October 26, 2026 09:48 — with
GitHub Actions
Inactive
BlueRaddish
temporarily deployed
to
github-app-auth
October 26, 2026 09:49 — with
GitHub Actions
Inactive
Member
|
/review |
Contributor
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): eb647fef2417
Model: gpt-5.6-sol
Overview
The documentation changes align both skills guides with the unchanged sample entry points and the FoundryChatClient environment contract. The mixed-skills endpoint also follows the repository's required project-scoped Foundry format, while existing client guards and tests confirm that the corrected values are forwarded or fail fast when absent. No publishable risk remains in the reviewed changes.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 27, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The file-based and mixed skills guides tell users to set
AZURE_OPENAI_MODEL, but both samples readFOUNDRY_MODEL. Following either guide with a custom deployment silently leaves the sample ongpt-4o-mini. The mixed skills guide also supplies an Azure OpenAI account URL where the sample needs a Foundry project endpoint.Description & Review Guide
main()functions against a recordingFoundryChatClientboundary reproduced two original custom-deployment failures and four passing controls. The corrected guides pass all six cases; the endpoint placeholder also satisfies the sample documentation convention. These checks stop before any agent or provider call and do not test live Foundry connectivity. The frozen all-workspace environment setup, ordinary scoped hooks, and normal native commit hooks passed, including the required whole-samples Ruff and Pyright checks. The resulting source commit was independently imported from its bundle against the pristine base and its exact three-line patch verified. The full unit suite and build were not run for this documentation-only change.Related Issue
N/A - trivial change. These are obvious corrections to existing sample configuration names and the required project endpoint format. No runtime API or design decision changes.
AI Assistance
AI assistance details: OpenAI Codex assisted with diagnosis, the three documentation corrections, deterministic verification, and this description.
Contribution Checklist