Skip to content

Pin GitHub Actions to full-length commit SHAs - #215

Open
Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
microsoft:mainfrom
danfiedler-msft:danfiedler/pin-actions
Open

Pin GitHub Actions to full-length commit SHAs#215
Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
microsoft:mainfrom
danfiedler-msft:danfiedler/pin-actions

Conversation

@danfiedler-msft

Copy link
Copy Markdown

Summary

This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions. This work is described in more detail at https://aka.ms/action-pinning.

Why?

Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.

This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.

What changed?

Action pinning: Third-party action references in .github/workflows/ that used mutable tag-based references (e.g., actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g., actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.

Dependabot configuration: .github/dependabot.yml has been updated to ensure a github-actions package-ecosystem section is present with a cooldown configuration (default-days: 7). If the file did not exist, it was created. If a github-actions section already existed, only the cooldown block was added or its default-days value was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.

Is this safe to merge?

Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes in action execution are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for actions/checkout@v7 can be found in the sha property in the JSON response for GET https://api.github.com/repos/actions/checkout/commits/v7).

Additional Information

For more information, please see https://aka.ms/action-pinning

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 gabriel-agent

The recommended pins in  microsoft/Graphormer#215  are valid and match their version comments:

┌──────────────────────┬────────────────────────────────────────┬─────────┬──────────────────────┐
│ Action               │ Pinned SHA                             │ Claimed │ Fact check           │
│                      │                                        │ version │                      │
├──────────────────────┼────────────────────────────────────────┼─────────┼──────────────────────┤
│ actions/checkout     │ 11d5960a326750d5838078e36cf38b85af6772 │ v4.4.0  │ Resolves to the      │
│                      │ 62                                     │         │ commit referenced    │
│                      │                                        │         │ directly by tag      │
│                      │                                        │         │ v4.4.0               │
├──────────────────────┼────────────────────────────────────────┼─────────┼──────────────────────┤
│ github/codeql-action │ 42947a340483f03ba47bb1a039b2c519aab3df │ v3.37.8 │ Resolves to the      │
│                      │ 85                                     │         │ commit targeted by   │
│                      │                                        │         │ tag v3.37.8          │
└──────────────────────┴────────────────────────────────────────┴─────────┴──────────────────────┘

Both are full 40-character commit SHAs, resolve in their respective repositories, and are appropriate immutable pins. The CodeQL version tag is annotated, but its resolved commit matches the SHA used in the workflow. No incorrect or mismatched pins were found.

🧑‍💻 gabriel-nonagent

shas confirmed, dependabot with 7 days ok

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants