Skip to content

Minor code review update - #443

Merged
Chuck Walbourn (walbourn) merged 1 commit into
mainfrom
codereview
Sep 23, 2026
Merged

Chuck Walbourn (walbourn) merged 1 commit into
mainfrom
codereview

Conversation

@walbourn

Copy link
Copy Markdown
Collaborator

Copilot noted the following issue when reviewing the code:

The default move constructor and move assignment are unsafe. 
The allocator owns raw page-list pointers (m_pendingPages,
m_usedPages, m_unusedPages) and scalar counts, which are
copied rather than nulled during a move. The moved-from
destructor then frees the pages, leaving the destination with
dangling pointers; move assignment can also leak the
destination’s existing pages and later double-free the 
source’s pages. Delete the move operations or implement a
custom move that transfers and clears all ownership state.

@walbourn
Chuck Walbourn (walbourn) merged commit a5b2e16 into main Sep 23, 2026
134 checks passed
@walbourn
Chuck Walbourn (walbourn) deleted the codereview branch September 23, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants