[HLSL] Fix GroupSharedLimit preview guard - #8872
Merged
Jack Elliott (JoeCitizen) merged 1 commit intoSep 2, 2026
Merged
Conversation
Guard the GroupSharedLimit execution tests and helpers with DIRECT3D_PREVIEW_BUILD rather than the preview SDK version define. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 35024739-8827-4a71-9077-e3221bfade26
Copilot started reviewing on behalf of
Jack Elliott (JoeCitizen)
September 1, 2026 23:33
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The consistent guard changes correctly isolate preview-only APIs and tests without affecting non-preview functionality.
Pull request overview
Aligns GroupSharedLimit execution-test compilation with the Direct3D preview build configuration.
Changes:
- Guards test registration, implementations, and helper APIs with
DIRECT3D_PREVIEW_BUILD. - Retains the SDK-version check only for compatibility definitions.
File summaries
| File | Description |
|---|---|
ExecutionTest.cpp |
Updates GroupSharedLimit test guards. |
HlslExecTestUtils.cpp |
Updates helper and compatibility-definition guards. |
HlslExecTestUtils.h |
Updates helper declaration guards. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jesse Natalie (jenatali)
approved these changes
Sep 1, 2026
Alex Sepkowski (alsepkow)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DIRECT3D_PREVIEW_BUILDD3D12_FEATURE_DATA_D3D12_OPTIONS_PREVIEWcompatibility definitionTesting
ExecHLSLTestswith NinjaExecHLSLTests.dllwithDIRECT3D_PREVIEW_BUILDexplicitly enabled