Repository navigation
Fix al-knowledge follow-ups and document the skill - #260
Merged
Jesper Schulz-Wedde (JesperSchulz) merged 1 commit intoNov 4, 2026
Merged
Jesper Schulz-Wedde (JesperSchulz) merged 1 commit into
Jesper Schulz-Wedde (JesperSchulz) merged 1 commit into
Conversation
- Admit JavaScript-only consultations: al-knowledge declares technologies [al, javascript], so Entry no longer filters out control add-in questions; Test-SkillIndex covers both technologies. - Reject inconsistent citations: validate_knowledge_response.py rejects duplicate reference or suppression paths and articles that are both cited and suppressed. DO states the invariant; regression tests cover it. - Document al-knowledge in using-bcquality.md and troubleshooting.md (skill discovery, explicit invocation, no-knowledge meaning). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the medium-priority follow-ups from the post-
v1.10repository audit for the newal-knowledgeskill (#222).JavaScript consultations were filtered out before retrieval
al-knowledgedeclaredtechnologies: [al]. Under READ's non-empty technology intersection, Entry dropped the onlyknowledge-queryaction whenever a caller suppliedtechnologies: [javascript]. That rejected supported questions such as packaged control-add-in resource requests, even though BCQuality ships applicable JavaScript UI articles andal-ui-reviewalready accepts[al, javascript].microsoft/skills/knowledge/al-knowledge.mdnow declarestechnologies: [al, javascript].Test-SkillIndex.ps1asserts Entry admitsknowledge-querywith either technology. It fails against the previous frontmatter.The validator accepted contradictory citation records
tools/validate_knowledge_response.pyaccepted an article cited inreferencesand also listed insuppressed, and duplicate reference paths with contradictory applicability. The schema'suniqueItemscompares whole objects, so it could not catch these.references[]andsuppressed[]. The validation guide lists the new rejections.Documentation omitted the new skill
docs/using-bcquality.md: the supplied-skill row and the/skills listcheck now includeal-knowledge.docs/troubleshooting.md: skill discovery checks all three skills. A new row covers answers without BCQuality citations, andno-knowledgefromal-knowledgeis explained as a coverage gap.Validation
Frontmatter (0 errors), 12 schema cases, 33 semantic/CLI tests, skill index, knowledge index/retrieval, review fixtures with the changed-path gate, fixture-context regressions, and review contract checks all pass locally. Relative links in the edited files resolve.
The remaining gap, a reproducible answer-quality evaluation, is tracked in #259. #212 is intentionally left to its reporter.