Add activity lifecycle E2E test fixture - #10365
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Agentic PR Review - Round 1Recommendation: Request ChangesWhat this PR doesThis PR adds a test-handler endpoint that prepares two Expense Users for externally run approval lifecycle tests. It maps the approver to the current BC service identity, replaces the submitter's approval setup, and disables the standard BC approval workflow. The setup path is otherwise narrow and matches the external test goal. However, assigning the service identity does not make that identity unique, while the approval code resolves it with SuggestionsS1 - Make the approver identity deterministic Risk assessment and necessityRisk: The changed code is test-only and does not affect the production app. The current identity setup can still make external lifecycle tests use the wrong Expense User, which gives unstable results and incorrect activity actors after a stale or interrupted run. Necessity: A deterministic setup endpoint is needed for the linked lifecycle E2E coverage. The scope is appropriate once the service identity is made unique for each fixture run.
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
|
Addressed S1 in 7c4f7a8. The fixture now clears the current service |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Summary
Add deterministic Business Central setup for the Expense Agent activity lifecycle E2E tests.
ExpenseTestHandler_ConfigureApprovalScenario.Expense Approval Setup.User Setupdependency.This is the BCApps companion to BC-ExpenseAgent PR #2391.
Tracking
Validation
git diff --check