Skip to content

Add activity log amount formatting metadata - #10359

Merged
Prangshuman Das (t-prda) merged 1 commit into
mainfrom
feature/activity-autoformat-647062
Aug 19, 2026
Merged

Add activity log amount formatting metadata#10359
Prangshuman Das (t-prda) merged 1 commit into
mainfrom
feature/activity-autoformat-647062

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Add currency-aware display metadata to the Expense Activity Log Entry amount snapshots.

  • LCY fields use local-currency formatting.
  • Native reimbursable and refundable fields use the stored reimbursement currency.
  • API decimal values and activity snapshot behavior are unchanged.

Issue

Fixes AB#647062

Validation

  • Diff validation passed.
  • Compile the Expense Agent app.
  • Verify amount formatting for LCY and reimbursement-currency scenarios.

Match activity snapshots to the Expense Report Header AutoFormat metadata.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Aug 18, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 18, 2026
@github-actions github-actions Bot added the Integration GitHub request for Integration area label Aug 18, 2026
@t-prda

Copy link
Copy Markdown
Contributor Author

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR adds currency-aware display metadata to the amount snapshots in Expense Activity Log Entry. The LCY fields use local-currency formatting, while reimbursable and refundable amounts use the stored Reimbursement Currency Code.

The metadata matches the established Expense Report Header and posted-document patterns. It changes only how decimal values are displayed; stored snapshot values, API decimal values, calculations, and control flow remain unchanged.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: Low. The change is limited to ExpenseActivityLogEntry.Table.al and adds declarative formatting metadata only. It does not change table fields, public APIs, events, calculations, or persisted values.

Necessity: The change is needed so activity-log amounts show the same currency context as the source expense report. The scope is narrow and follows existing Expense Agent formatting patterns.


[AI-PR-REVIEW] version=1 promptVersion=1 system=github pr=10359 round=1 by=t-prda at=2026-08-18T14:11:22.7746946Z lastSha=d4f236c218a5578f78b8716aec20a276e25f8519 reviewKey=b378ae0460ee59bcc07a148da437d65eeddacc7f629a7fe370cd05a3efcda42c suggestions=none

@onbuyuka Onat Buyukakkus (onbuyuka) added Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership and removed Integration GitHub request for Integration area labels Aug 18, 2026
@t-prda
Prangshuman Das (t-prda) added this pull request to the merge queue Aug 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 18, 2026
@t-prda
Prangshuman Das (t-prda) added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit f3d1b3f Aug 19, 2026
339 of 344 checks passed
@t-prda
Prangshuman Das (t-prda) deleted the feature/activity-autoformat-647062 branch August 19, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants