Repository navigation
Make the parameter help shortcut translatable - #1393
Merged
microbit-matt-hillsdon merged 3 commits intoNov 4, 2026
Merged
microbit-matt-hillsdon merged 3 commits into
microbit-matt-hillsdon merged 3 commits into
Conversation
The shortcut shown in the Manual parameter help option was built in code, so translators couldn't localise the key names (for example, Strg in German). Move it into two source strings, one for Mac and one for other platforms. English is unchanged and existing translations still apply. Closes microbit-foundation#1193
| @@ -0,0 +1,52 @@ | |||
| /** | |||
Collaborator
There was a problem hiding this comment.
Let's drop this. There are a lot of translated strings and it's not reasonable to cover them all in this way, so I'm reluctant to add this (especially as AI will take it as a pattern to follow).
microbit-matt-hillsdon
self-requested a review
November 4, 2026 12:39
microbit-matt-hillsdon
approved these changes
Nov 4, 2026
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks!
microbit-matt-hillsdon
merged commit Nov 4, 2026
5d8de2a
into
microbit-foundation:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1193
The shortcut in the "Manual (Ctrl+Shift+Space)" parameter help option was built in code, so translators couldn't localise the key names (for example, Strg in German).
parameter-help-shortcut("Ctrl+Shift+Space") andparameter-help-shortcut-mac("Cmd+Shift+Space"), with descriptions asking translators to use local key names.Manual ({shortcut})and its existing translations are unchanged, and English reads exactly as before.Checked with typecheck, lint, unit tests,
i18n:tidy --check, the settings, accessibility and autocomplete e2e tests, and a build. I also checked the dialog in English and German, and with a temporary local German translation to confirm it comes through.One thing worth knowing: the select is fixed at 28ch, so a longer translation gets clipped when the select is closed. The open list shows it in full.
AI-assisted.