Repository navigation
feat(scripts): add dao liquidation proposal template - #499
Merged
Merged
Conversation
Contributor
|
Repository Guard
Repository GuardCargo dependency pinning
Cross-program Anchor/Solana version consistency
solana-program crate pin
Anchor.toml solana_version
Crate minimum age
Yarn package.json pinning
npm minimum age
Workflow toolchain consistency
GitHub Action SHA pinning
Sensitive program / config changes
Overall status: pass Lockfile freshness (Cargo.lock + yarn.lock) is checked by the workflow directly and cannot be bypassed. The sensitive-diff section is a review hint - CODEOWNERS handles the actual merge gate. |
…efresh setup blockhashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been no script for winding a DAO down, and the vault transaction a liquidation needs doesn't fit a Squads transaction: its whole message is instruction data, so the transaction creating it blows the 1232-byte limit. Now
scripts/v0.6/liquidationTemplate.tsputs the full liquidation up as one futarchy proposal, oversized vault transactions go behind a frozen lookup table automatically, and once the proposal executes the vault's base and USDC accounts belong to the MetaDAO ops vault, which burns and pays out without a second vote.What changed
RESUME_SQUADS_PROPOSALinstead of re-run.withdrawAllLiquiditytakes the whole position with zero minimums, so a price move during the vote can't fail it.claimMeteoraFees,revokeMintAuthority(vault-held or via a mint governor the vault administers),approveDelegateandtransferTokenAccountOwnershipare new; the last two are the reversible and irreversible ways of handing a vault token account over.

Confidence Score: 5/5
The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found.Summary
Adds a DAO liquidation template and lookup-table support for large Squads proposals.
Reviews (2) · Last reviewed commit: "fix(scripts): let any oversized proposal..." · Reviewed by Greptile