Repository navigation
fix: skip reparse points during -r on Windows - #4860
Open
Nmd-sketch wants to merge 1 commit into
Open
Nmd-sketch wants to merge 1 commit into
Nmd-sketch wants to merge 1 commit into
Conversation
UTIL_isLink always returned 0 on non-POSIX platforms, and the Windows branch of UTIL_prepareFileList() had no reparse-point guard. As a result -r traversed junctions and symlinks found inside the input tree, combined with --rm this compressed and deleted files located outside the directory the user passed. Added a _WIN32 branch to UTIL_isLink() querying GetFileAttributesA(), with the FILE_ATTRIBUTE_REPARSE_POINT test applied only when the lookup succeeds. Such entries are skipped in UTIL_prepareFileList() unless --follow-links is set, mirroring the POSIX branch, including its level-2 warning. Covered by a new playTests.sh test asserting that a junction (Windows) or symlink (POSIX) pointing outside the tree is left untouched by -r --rm
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTIL_isLink always returned 0 on non-POSIX platforms, and the Windows branch of UTIL_prepareFileList() had no reparse-point guard. As a result -r traversed junctions and symlinks found inside the input tree, combined with --rm this compressed and deleted files located outside the directory the user passed.
Added a _WIN32 branch to UTIL_isLink() querying GetFileAttributesA(), with the FILE_ATTRIBUTE_REPARSE_POINT test applied only when the lookup succeeds. Such entries are skipped in UTIL_prepareFileList() unless --follow-links is set, mirroring the POSIX branch, including its level-2 warning. Covered by a new playTests.sh test asserting that a junction (Windows) or symlink (POSIX) pointing outside the tree is left untouched by -r --rm
What and why
Fixes #4853.
After the fix the junction is skipped with
Warning : tree\link is a symbolic link, ignoring. Mirroring the existing POSIX behavior;
--follow-links still opts back into the traversal. The Windows path now costs one extra
GetFileAttributesA per listed entry, matching the per-entry lstat the POSIX branch has always done.
The new playTests.sh case creates a junction (Windows) or symlink (POSIX) pointing outside
the tree and asserts -r --rm leaves the outside file untouched. Verified both ways locally. Fails
without the fix (outside file compressed, original deleted by --rm), passes with it. Full CTest
suite passes.
Checklist
A gain in one configuration is not a general gain: see the Performance section of CONTRIBUTING.md.
Tools used
AI coding agent (Local LLM harness) was used to analyze the issue, draft the fix and write the tests.
All work was human-directed and reviewed and the failing-without-the-fix verification was done
locally on Windows with MSVC 2022. The issue report itself also disclosed AI-assisted analysis.