Repository navigation
Conversation
Co-authored-by: gong-flying <gongxiaofei24@iscas.ac.cn>
|
Hi @BoBoDai! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hi, @Cyan4973 i copy the rvv xxh3 code from xxHash repo, and through fuzzer tests by qemu. |
|
This looks correct, (in fact, we even disable it explicitly to ensure it does not occupy binary space). |
|
Yes, I conducted the xxh3 fuzzer test by deleting this line. |
This pr resolved #4471 .
Add RISCV-V implementation from xxhash repo.
Relevant performance tests are reflected in xxHash pr #1070 and #1066
I conducted testing by replacing the hash function in the fuzzer and conduct testing through qemu.
Although zstd does not currently use xxh3, this will better support teams who wish to use zstd and xxh3 on RISCV devices.