Repository navigation
protobuf-m 35.1: Protocol Buffers as import mcpplibs.mwrap.protobuf (+ protogen) - #1
Merged
Merged
Conversation
Thin wrapper over compat.protobuf 35.1 (over compat.abseil 20250512.1). tools/surface.py reads the release headers with clang and writes the modules: the root (messages, descriptors, reflection, the well-known types), io, util, compiler, macros, and io.gzip behind the gzip feature.
…ms, macros, header mixing
On little-endian aarch64 parse_context.h's VarintParse<T> calls the static VarintParseSlowArm overloads; Clang instantiates it at the end of the module unit, where internal-linkage entities of the fragment are not visible (Linux arm64 and macOS LLVM rows). src/detail/epilogue.hpp instantiates the two specialisations explicitly in the fragment.
…index mcpp-index#845)
…imported enumeration in GoogleTest)
…lates (GCC 16 aarch64 ICE)
…s with the root and a namespace-scope decltype)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: mcpplibs/mcpp-index
.agents/docs/2026-11-19-add-openssl-abseil-protobuf-mwrap-plan.md§6.3, §6.5, §5.4.Form. Thin wrapper over
compat.protobuf35.1 (overcompat.abseil20250512.1). Packagemcpplibs.mwrap.protobuf35.1, tagmwrap-35.1. Platforms linux (x86_64, aarch64), macos, windows, emscripten.Modules. root
mcpplibs.mwrap.protobuf(710 names: messages, descriptors, reflection, arenas, repeated fields, maps, TextFormat, the well-known types; re-exports the rest),.io(33),.util(51: json, MessageDifferencer, TimeUtil + operators, FieldMaskUtil, delimited),.compiler(7: Importer, Parser … — already in the runtime, no feature),.macros(6 version constants +GOOGLE_PROTOBUF_WIRE_FORMAT_MAKE_TAG),.io.gzip(featuregzip). Noabslname exported. Derived bytools/surface.py(clang AST), audited bytools/check_exports.py(re-derived on the Linux LLVM row).Features.
codegen(protoc host tool, same release, + theprotogenrule),gzip,upb(forwarded so gRPC + protobuf link one protobuf).protogen 35.1 (
rules/,mcpplibs.protogen, moduleprotogen): the generic protoc layer of grpc-m's grpcgen (same L0–L3 API), messages only by default, plugins as a parameter, plus.liteand.descriptor_set. It asks forcompat.protobufby qualified name: next to this package,dep_dir("protobuf")is ambiguous.Verification (local, Linux x86_64, GCC 16.1 and LLVM 23.1.3): 4 test binaries (wire bytes pinned, text/JSON round trips, Timestamp/Duration/Struct/Any/wrappers, MessageDifferencer, FieldMaskUtil, coded + delimited streams, Arena, a .proto parsed at run time + syntax error, macros, header mixing); examples/gzip and examples/codegen (protoc built, code generated, used with the module) run; the message template instantiated and run.