Repository navigation
0.12.0: openkal 0.26 - #22
Open
Sunrisepeak wants to merge 1 commit into
Open
Sunrisepeak wants to merge 1 commit into
Sunrisepeak wants to merge 1 commit into
Conversation
- openkal ^0.26.0, in the manifest and in the examples; the example's board names openkal-uefi 0.12.0 - no code changes: what 0.26 requires is of openkal.process, which this implementation does not provide, and the arguments a program receives are already kept at their measured size (clause 7.6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openkal 0.26.0 (mcpplibs/openkal#69) advances the specification's minor version, so every implementation releases a version that declares it. This is openkal-uefi's.
What changes
mcpp.toml: version 0.12.0,openkal = "^0.26.0".examples/hello/mcpp.toml,examples/std/mcpp.toml:openkal = "^0.26.0".examples/board/mcpp.toml: the kernel-abi layer isopenkal-uefi@0.12.0, as 0.11.0 moved it.README.md: one paragraph stating that nothing but the specification's version changes.No code changes, and why
Both requirements of 0.26 are of
openkal.process(clause 7.6, a start bounded by the environment alone; clause 7.18, a unit claimed only where a reference can be made), and this implementation does not provide that interface:kal_process_spawnandkal_process_job_createare not defined. The receiving side of clause 7.6 was read:src/start.cppkeeps the arguments in pool memory of their measured size (from_shell,from_load_options) andsrc/env.cppindexes that vector; there is no table of a fixed number of arguments. The firmware gives a program no variables.What was run
Nothing was built or booted locally. In this pull request's CI, with the specification at
openkal-0.26.0:examples/hellobuilds as an EFI application, boots under OVMF and returns its status, and receives the Shell's arguments and uses its volume; it cross-builds from macOS and Windows.Expected to wait (the platform release)
The last step of "boots under OVMF as BOOTX64.EFI" builds
examples/stdthroughopenkal-platform@0.28.0, whose group names openkal-musl 0.29.6:It holds once the platform is released for openkal 0.26. The platform pin in
examples/std/mcpp.toml, inREADME.mdand in the workflow moves with that release and is not changed here. openkal-musl admits openkal-uefi as>=0.10.0, <0.12.0, which that release also has to widen for 0.12.0.