Repository navigation
0.20.4: a system this package does not know takes the general selections (builtins, the 486, the allocator) - #75
Merged
Conversation
…e, the allocator by the implementation's statement
…brary states for one implementation
… was measured, musl's own elsewhere
This was referenced Nov 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect
Three tables named the systems they applied to, so a row a platform defines for a system this package does not know took none of them, or the wrong one:
linux,openkalanddos: another ELF row was built with no builtins at all (undefined symbol: __divdi3,__atomic_load);*bf2.cexclusion of the 486 was DOS's and the i386 ok image's;os = "none"andos = "dos"and mimalloc elsewhere, which asks the implementation for a random source, far-apart arenas and threads.The change
Each table names the exception and leaves the rest to the general case:
cfg(all(object-format = "elf", not(os = "freebsd"), not(os = "none")))— the ELF rows that state no selection of their own;cfg(all(arch = "i686", not(os = "linux")));Every row served before selects what it selected.
A first version of the allocator edge asked
cfg(interface = "openkal.random"). That is unsound for a dependency edge, which is selected before the graph is resolved: the predicate is false there whatever the implementation states. CI showed it (the hosted Linux build lost its C library); the condition is now the row's own words.CI tool
tools/branch-graph.shread caret ranges only. openkal-musl states>=0.10.0, <0.12.0for openkal-uefi since 0.29.8, and the script ended there with no message. It reads comparator ranges now.Measured
An i386 row a platform defines over an implementation outside this package's knowledge (seven interfaces, no random source, no threads): C++23 with
import std, exceptions,std::formatandstd::filesystembuilds and runs, with-femulated-tlsas the row's flag.