Repository navigation
0.2.0: the kernel's refusal of a start for its size is kal_err_no_space (openkal 0.26) - #5
Open
Sunrisepeak wants to merge 2 commits into
Open
Sunrisepeak wants to merge 2 commits into
Sunrisepeak wants to merge 2 commits into
Conversation
…ce (openkal 0.26) - E2BIG from fexecve is kal_err_no_space, where it was kal_err_io (clause 7.6); no bound of this implementation's own existed upon an argument vector or an environment - observable units remain unclaimed and kal_process_job_create answers kal_err_not_supported (clause 7.18) - openkal ^0.26.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openkal 0.26.0 (mcpplibs/openkal#69) requires of every implementation that a start be bounded by the environment alone (clause 7.6) and that observable units be claimed only where a reference can be made (clause 7.18). This is openkal-freebsd's release for it.
What changes
src/common.h,src/sys.h:E2BIGiskal_err_no_space. It was not named inokf::translateand fell tokal_err_io.fexecveanswers it when the arguments and the environment exceedARG_MAX; the copy reports the error number through the report pipe and the starter translates it.mcpp.toml: version 0.2.0,openkal = "^0.26.0".README.md,CHANGELOG.md: the section for 0.2.What does not change, and why
kal_process_spawnallocates both vectors at their measured size (argc + 1,envc + inherited + 2slots), andkal_env_arg*/kal_env_var*read the vectors the kernel gave the program where they lie (src/core.cpp,src/start.cpp); there is no table on either side.kal_process_propsdoes not stateKAL_PROCESS_PROP_JOB_OBSERVEandkal_process_job_createanswerskal_err_not_supported, which is what 0.26 requires of an implementation that does not claim the property.What was measured
tools/check-standalone.shwith clang++ 23.1.3 on a Linux host: every source compiles for x86_64 and aarch64 without a system header. Nothing was run on FreeBSD locally.openkal-0.26.0: 326 observations held, 0 did not hold, 13 not observed (main, with openkal 0.25.3's suite: 322 held). The four observations of 0.26 are the difference and all hold: 2,000 arguments, 2,000 variables, an argument of 1 MiB, and "an implementation that does not claim observable units refuses to declare one".Expected to wait (the platform release)
Both standalone conformance jobs build for
<arch>-freebsd-muslthrough the engine's default platform and are refused:They hold once the platform is released for openkal 0.26.
Not verified
E2BIGuntranslated the refusal would not have held.