Repository navigation
0.2.0: openkal 0.26 - #5
Open
Sunrisepeak wants to merge 1 commit into
Open
Sunrisepeak wants to merge 1 commit into
Sunrisepeak wants to merge 1 commit into
Conversation
- openkal ^0.26.0; openkal-dos-tools carries the same version (one archive) - no code changes: what 0.26 requires is of openkal.process, which is absent here, and what a program receives is bounded by DOS alone (the command tail's 127 bytes, the environment block read where it lies)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openkal 0.26.0 (mcpplibs/openkal#69) advances the specification's minor version, so every implementation releases a version that declares it. This is openkal-dos's.
What changes
mcpp.toml: version 0.2.0,openkal = "^0.26.0".tools/mcpp.toml(openkal-dos-tools): version 0.2.0. The two packages are one tag and one archive in the index, and 0.1.1 moved both; the seal itself is unchanged andtools/src/stub_bytes.his not touched.README.md: one paragraph stating that nothing but the specification's version changes.No code changes, and why
Both requirements of 0.26 are of
openkal.process(clause 7.6, a start bounded by the environment alone; clause 7.18, a unit claimed only where a reference can be made). This implementation does not provide that interface:kal_process_spawnandkal_process_job_createare not defined.The receiving side was read.
src/start.cppkeepstail[128]andwords[66]for the arguments: the command tail of the segment prefix is one byte of count and at most 127 bytes of text, so at most 64 words and the name; the room is the environment's bound and not one of this implementation's.src/env.cppwalks the environment block in conventional memory and keeps no table of variables.What was run
Nothing was built or run locally; the row runs under DOSBox Staging in CI.
Expected to wait (the platform release)
The job
programsbuilds the examples and tests throughopenkal-platform@0.28.0and is refused at its first program:It holds once the platform is released for openkal 0.26. The platform pin in
examples/*/mcpp.toml,tests/*/mcpp.tomlandREADME.mdmoves with that release and is not changed here. The jobsstubandokdos(Linux, macOS, Windows) do not depend on it and pass.