Repository navigation
fix(compat.sdl3): addchdir by its _np name alone, for a system glibc before 2.40 (revision 3) - #854
Merged
Merged
Conversation
…before 2.40 (revision 3) The generated SDL_build_config.h defined both HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR and HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP. The plain posix_spawn_file_actions_addchdir is glibc 2.40's; built against an older system C library (mcpp build --sysroot glibc@system on Ubuntu 24.04, glibc 2.39) SDL_posixprocess.c stops on its implicit declaration, and SDL3 is the only package of a windowed omui application that does. With the _NP define alone, SDL_posixprocess.c maps the call to posix_spawn_file_actions_addchdir_np itself — glibc since 2.29, musl since 1.1.24, and the toolchain's glibc 2.44 still has it — so the default build is unchanged in what it does. Revision 3, floor 3 for 3.4.18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compat.sdl3 3.4.18's generated
SDL_build_config.hdefines bothHAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIRandHAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP. The plainposix_spawn_file_actions_addchdiris glibc 2.40's, so a build against an older system C library stops inSDL_posixprocess.c:(
mcpp build --sysroot glibc@system --profile releaseof a windowed omui application on Ubuntu 24.04, glibc 2.39: every other package compiles.)With
_NPalone,SDL_posixprocess.cmaps the call toposix_spawn_file_actions_addchdir_npitself — glibc since 2.29, musl since 1.1.24, and the toolchain's glibc 2.44 has it too — so the default build behaves as before.pkgs/c/compat.sdl3.lua: the define kept as/* #undef … */with the reason; revision 3, floor 3 for 3.4.18.Not verified end to end against glibc 2.39 here: the build read the already-installed payload's generated config; that build follows this revision's release.