Repository navigation
add yandere-chan.binary_tree 0.1.4 - #848
Merged
Merged
Conversation
Form A package: the tag tarball carries the library's own mcpp.toml, which declares the header library and the C++23 module wrappers (binary_tree, Yc.intrusive_binary_tree, Yc.binary_tree, Yc.parent_aware_binary_tree). Adds tests/examples/binary_tree-module, which imports the lib root and every wrapper and asserts owning/intrusive tree behavior.
0.1.0 and 0.1.1 fail a libc++ module consumer because placement new is not declared when allocator_traits is parsed. 0.1.2 includes <new> before <memory> in the owning headers and in the module GMF. Update the descriptor, the test member dependency and the plan.
Use the lowercase hyphenated namespace yandere-chan for the package identity and the index file. Move to 0.1.3, which carries the same libc++ <new> fix under the new namespace; 0.1.0-0.1.2 stay unlisted.
libc++'s allocator_traits::construct instantiates __construct_at with a placement-new default argument in the importer's context; the module GMF <new> is not reachable from an importer. Include <new> before the imports in the consumer (no-op on MSVC STL/libstdc++) and correct the design note.
clang's combined -fmodule-output build does not make the module GMF <new> visible to importers, so libc++ consumers instantiating allocator_traits::construct needed #include <new>. The three module interfaces now export using ::operator new/::operator delete; both tests build without <new>, including an umbrella-only test. Update the descriptor to 0.1.4 and the plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shape
Form A mcpp-native package, namespace
yandere-chan, namebinary_tree. The0.1.4tarball carries the library's ownmcpp.toml(mcpp = "*/mcpp.toml"): header library, the three module wrappers (Yc.intrusive_binary_tree,Yc.binary_tree,Yc.parent_aware_binary_tree), andsrc/binary_tree.cppmas the lib root (import binary_tree;).The libc++ placement-new fix
The earlier Linux LLVM failure was clang's combined
-fmodule-outputmodule build not making the module's GMF<new>visible to importers (llvm/llvm-project#218246, #59601); libc++'sallocator_traits::constructlooks placement new up when the consumer instantiates it. A consumer-side#include <new>worked but is surprising.0.1.4 exports the global placement
operator new/operator deleteusing-declarations from each module interface:An importer can then instantiate the tree without including
<new>, and a consumer that includes<new>still compiles. The declarations sit after the imports because GCC requires post-module imports to be contiguous. The umbrella module re-exports them throughexport import, which a dedicated umbrella-only test checks.0.1.0-0.1.3 are not listed (old
YandereChan2namespace; 0.1.3 also predates the export).Mirror
No
mcpp-resmirror yet; plain-string GLOBAL URL fallback, no invented CN mirror.Test member
tests/examples/binary_tree-module/now hasbinary_tree_module.cpp(imports the umbrella and every wrapper, asserts owning/intrusive behavior) andbinary_tree_umbrella.cpp(imports onlybinary_tree). Neither includes<new>or a library header. Both use the[indices] yandere-chan = { path = "../../.." }redirect.Verification
mcpp test -p binary_tree-module --cache off:2 passed; 0 failed.mcpp build(clang),mcpp build --toolchain msvc@system, GCC 16.1 on all four.cppm.e7bd88adaa156219d87db05cbe4bc0dd5447ee7c7736f138f0870ebdfa706853.