Repository navigation
feat(compat.sdl3): switches no-render and no-hidapi for 3.4.18 (revision 1) - #827
Merged
Merged
Conversation
…ion 1) Two features, off by default, so the default build is the one it was: each sets an upstream *_DISABLED define at the end of the generated SDL_build_config.h, after every platform's config (MCPP_FEATURE_<NAME> is defined for the package's own units). - no-render: SDL_RENDER_DISABLED, the 2D renderer and its back ends - no-hidapi: SDL_HIDAPI_DISABLED, and SDL_JOYSTICK_HIDAPI undefined, so HIDAPI's game-controller drivers go (evdev's joystick path stays) 3.4.18's packaging is revision 1 with floor 1: the generated header is part of the installed payload, so installed copies are replaced to take the switches. Measured on Linux x64 (GCC 16, -O3) in a program on SDL_GPU and SDL_Renderer loading 18,473,342 bytes: no-hidapi 18,226,585 (-246,757), its window, input and GPU tests passing; both switches 17,998,177 (-475,165). With no-render, SDL_CreateRenderer reports "SDL not built with rendering support".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two features, off by default, so the default build is the one it was: each sets
an upstream *DISABLED define at the end of the generated SDL_build_config.h,
after every platform's config (MCPP_FEATURE is defined for the
package's own units).
HIDAPI's game-controller drivers go (evdev's joystick path stays)
3.4.18's packaging is revision 1 with floor 1: the generated header is part of
the installed payload, so installed copies are replaced to take the switches.
Measured on Linux x64 (GCC 16, -O3) in a program on SDL_GPU and SDL_Renderer
loading 18,473,342 bytes: no-hidapi 18,226,585 (-246,757), its window, input
and GPU tests passing; both switches 17,998,177 (-475,165). With no-render,
SDL_CreateRenderer reports "SDL not built with rendering support".