Skip to content

V2 Lab4 - Camille Valenciennes - #904

Closed
kamsssy wants to merge 4 commits into
mathurinm:mainfrom
kamsssy:Valenciennes_assignment
Closed

kamsssy wants to merge 4 commits into
mathurinm:mainfrom
kamsssy:Valenciennes_assignment

Conversation

@kamsssy

@kamsssy kamsssy commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Second pull request to fix "validate_data" bug

@kamsssy
kamsssy force-pushed the Valenciennes_assignment branch from 6768a1c to 227ce9d Compare November 10, 2026 17:04
@mathurinm

Copy link
Copy Markdown
Owner

don't force push :)

@kamsssy

kamsssy commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

flake8 detects an error that makes no sense (flagged unused import of validate_data even though there is no import in my code) and I was trying (unsuccessfully) to fix it
I still have no idea of what’s causing it

@mathurinm

Copy link
Copy Markdown
Owner

The reason is that I added this import (L28 of the file) and pushed to upstream/main.
Do git pull upstream main and check for import validate_data, you will see that it is there (actually, I believe it already is; flake8 is not wrong).

@mathurinm

Copy link
Copy Markdown
Owner

done !

@mathurinm mathurinm closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants