Prevent webpacking from producing invalid names for region stylesheets - #1565
Open
dpvc wants to merge 1 commit into
Open
Prevent webpacking from producing invalid names for region stylesheets#1565dpvc wants to merge 1 commit into
dpvc wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1565 +/- ##
==========================================
Coverage 87.12% 87.12%
==========================================
Files 392 392
Lines 89187 89187
Branches 5063 3370 -1693
==========================================
Hits 77706 77706
Misses 11481 11481 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the id attribute for the style-sheets used for the various Region classes. It currently is based on the class's
nameproperty, which should be the class name, but when webpacked the name can be changes to some random characters, and it is possible for that to produce an invalid element id. E.g., I had one of the region classes be named$E, and that lead to an error in the browser forMJX-$E-stylesbeing used as theidattribute.The solution used here is to use the
classNameproperty rather thanname, since that is something likeMJX_hoverand won't be changed by webpack.