Revert change from feature/component-types that prevents multiple input jax from registering properly. - #1564
Open
dpvc wants to merge 1 commit into
Open
Revert change from feature/component-types that prevents multiple input jax from registering properly.#1564dpvc wants to merge 1 commit into
dpvc wants to merge 1 commit into
Conversation
…ut jax from registering properly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1564 +/- ##
==========================================
Coverage 87.12% 87.12%
==========================================
Files 392 392
Lines 89187 89192 +5
Branches 5063 3370 -1693
==========================================
+ Hits 77706 77711 +5
Misses 11481 11481 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change to
startup.tsin thefeature/component-typesbranch causes problems when multiple input jax are loaded, as intex-mml-chtml, etc. Only the first gets registered. This reverts the change so that it works as before.