Use the ui/safe data URL filter for the values used in \data TeX macros - #1561
Open
dpvc wants to merge 1 commit into
Open
Use the ui/safe data URL filter for the values used in \data TeX macros#1561dpvc wants to merge 1 commit into
\data TeX macros#1561dpvc wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1561 +/- ##
========================================
Coverage 87.12% 87.12%
========================================
Files 392 392
Lines 89098 89102 +4
Branches 5046 5048 +2
========================================
+ Hits 77628 77632 +4
Misses 11450 11450
Partials 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR causes the
\datamacro in TeX to use theui/safedata filter when the safe extension is loaded. This prevents the\datamacro from entering data attributes that could be harmful within frameworks that use data attributes for code control.It also removes a reference that looks up a
data-MJXattribute that is never actually set anywhere in the code.In addition, it cleans up the mechanism used to set the MathML attribute and class filters by adding a service method to the MathML and MathMLCompile objects to set those values rather that casting the jax to
anyand setting them by hand.Finally, it corrects an incorrect type that appears in the jsDoc for one of the safe methods.