Skip to content

Fixed color brightness calculation #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swarty wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed color brightness calculation #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ecb647
fixed color brightness calculation
swarty Sep 1, 2026
bc13fb7
tiny fix
swarty Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,11 @@ export class Color {
return `rgba(${c},${this.a})`;
}

/** Get the brightness of this color. */
/** Gets the brightness of this color.
* docs: https://www.w3.org/WAI/WCAG22/Techniques/general/G145
*/
get brightness() {
return (this.r * 299 + this.g * 587 + this.g * 114) / 1000;
return (this.r * 299 + this.g * 587 + this.b * 114) / 1000;
}

/** Converts this color to an HSL array. */
Expand Down
Loading