feat: P8 runtime performance and resilience hardening - #303
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78c5d009f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current head after the P8 second-audit cleanup, with extra attention to telemetry timestamp/quality semantics, allocation metrics, concurrency/regression risks, and whether the production batching/virtualization/reconnect contracts remain unchanged. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4445f6d44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current head after addressing all three second-review P2 findings: strict complete relay timestamp parsing, monotonic allocation-rate timing, and explicit current-managed vs last-GC heap semantics. Focus on any remaining regression or correctness risks before field test. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ad2babfc1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address that feedback Please fix the remaining P1 on the current PR branch, not by weakening tests and not by adding a parallel runtime. Requirements:
After implementing, please update the P8 docs if needed. Do not merge the PR. |
|
To use Codex here, create an environment for this repo. |
|
Cross-thread integration note: COMTRADE P1D.7 is now on |
|
Cross-thread coordination note added to |
|
Final coordination update from the completed COMTRADE lane: latest |
Summary
Implements the P8 Runtime Performance & Resilience hardening layer on top of the FAT workstation convergence work in #296.
This PR preserves a strict protection-workstation invariant: Report/GOOSE/SOE/process evidence remains event-by-event; only the visual latest-value projection may be coalesced.
A second regression audit was completed before closure. That audit deliberately removed two unused experimental helpers (
LatestValueUiBatcherandPooledByteBufferLease) rather than adding parallel authorities or speculative pooling to a production path that is already working.Final P8 coverage
ConcurrentQueue. No second batching framework is introduced.ArrayPoolinsertion.Regression coverage
Safety decisions from the second audit
value ?? 0or equivalent missing-data promotion is introduced.ReceivedAtUtcis local receipt metadata and is never substituted for missing relay time.See
docs/P8_RUNTIME_PERFORMANCE_RESILIENCE.mdfor the final invariants and audit decisions.Stacked base:
fix/fat-workstation-convergence/ #296. Do not merge into the lower stack until CI and field gates are accepted.