Repository navigation
Fix UrlField and FileField may execute JS code on click - #11409
Merged
Merged
Conversation
URL is 25x slower, but most important, it requires window to be defined, which forbids SSR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
<UrlField>renders a record's field value directly as an anchor'shrefattribute with no scheme validation or sanitization. If the backing data source (a REST/GraphQL API, any data provider) returns ajavascript:URI for that field instead of a URL,UrlFieldplaces it unmodified into the DOM. Clicking the rendered link executes it in the admin user's session.UrlFieldis documented purely as "displays a url," with no warning that the field value must be scheme-validated by the caller, unlikeRichTextField's documented sanitization requirement.Solution
Use a scheme detection function before putting the record field in the
hrefprop.If
javascript:is detected, render an empty link and log an error in the console.Closes #11408
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature