Repository navigation
Verify genome cache LRU eviction order - #1368
Open
simplyshree wants to merge 1 commit into
Open
simplyshree wants to merge 1 commit into
simplyshree wants to merge 1 commit into
Conversation
Author
|
@jonbrenas, @tristanpwdennis could you please review this focused test addition for issue #1244? It verifies that _load_genome_seq retains the recently used chromosome and evicts the least recently used one. |
simplyshree
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression coverage for true LRU access ordering in Annotator._load_genome_seq. The test confirms that re-accessing chr1 keeps it cached while chr2 is evicted after loading chr3 with a cache size of 2.
Verification
Closes #1244