Skip to content

GH1366: Replace deprecated pandas is_period_dtype in anoph/frq_base.py #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HeeraThakurrr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GH1366: Replace deprecated pandas is_period_dtype in anoph/frq_base.py #1367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions malariagen_data/anoph/frq_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _prep_samples_for_cohort_grouping(

# Validate the specified period_by column contains pandas Periods (or nulls).
s_period_by = df_samples[period_by]
if not pd.api.types.is_period_dtype(s_period_by.dtype):
if not isinstance(s_period_by.dtype, pd.PeriodDtype):
non_null = s_period_by.dropna()
if len(non_null) > 0 and not non_null.map(type).eq(pd.Period).all():
raise TypeError(
Expand Down Expand Up @@ -115,7 +115,7 @@ def _build_cohorts_from_sample_grouping(
# Add cohort helper variables.
# Vectorized extraction of period start/end times.
period = df_cohorts["period"]
if pd.api.types.is_period_dtype(period.dtype):
if isinstance(period.dtype, pd.PeriodDtype):
df_cohorts["period_start"] = period.dt.start_time
df_cohorts["period_end"] = period.dt.end_time
else:
Expand Down