ci: 镜像仓库凭据改从 common-shared 读取 - #203
Merged
Merged
Conversation
按 infra 的"共享凭据收口到 common 项目"规则,ACR_AK_ID / ACR_AK_SECRET / ACR_REGISTRY 改为从 common-shared 的 dev /deployment 读取,不再依赖 speakup-secrets 里的私有副本(video-2022 的部署流水线用同一路径)。 新增的读取步骤放在 speakup-secrets 递归读取之后,让 common 的值最终生效。 迁移期两处同值,等本流水线部署验证通过后再删除 speakup-secrets prod /deployment 里的三个旧键。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为什么
infra 的密钥规则要求"共享凭据收口到 common 项目的受限路径",但 ACR 镜像仓库凭据(
ACR_AK_ID/ACR_AK_SECRET/ACR_REGISTRY)此前只存在speakup-secrets的 prod/deployment里,属于单仓库私有副本。video-2022 恢复上线(makewheels/video-2022#114)也要推同一个
b4命名空间,因此把这三个键收口到了common-shared的 dev/deployment(该 folder 此前已存在但为空,正是为共享部署凭据预留的位置)。值已按指纹比对确认与源一致。改了什么
只加了一个 secrets-action 步骤,从
common-shareddev/deployment读取,位置在speakup-secretsprod 递归读取之后,因此 common 的值最终生效。13 行新增,无其它改动。迁移与验证顺序
common-shareddev/deployment有读权限。speakup-secretsprod/deployment里的ACR_AK_ID/ACR_AK_SECRET/ACR_REGISTRY三个旧键(符合"新值先写、验证消费者切换后再删旧副本")。在步骤 1 验证通过前不要删旧键 —— 删早了会让生产部署直接失败。
影响面
ACR_AK_ID/ACR_AK_SECRET/ACR_REGISTRY只被ci-cd.yml使用(全仓 grep 确认),storage-maintenance.yml读 prod/deployment但只用 SSH 相关键,不受影响。