Repository navigation
teams: align CISA checks with pinned baseline - #2788
JeremyFinney-lgtm wants to merge 5 commits into
Conversation
Pin the CISA framework to ScubaGear 92e5f2e, add the Security Suite requirements, mark removed policies, move EXO 9.5 and 10.3 to SECURITYSUITE 1.1 and 1.2, add 1.3 and the 1.4 shim of ORCA.158, and remove the superseded EXO 9.1, 9.3, 10.1 and 10.2 tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add 14 CISA Teams checks and framework mappings, with unified app settings retrieval and lifecycle handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This pull request changes files that a website explainer describes:
If the change alters what the explainer shows (a gate, a reason code, a command, a count), update its composition and its chapters in |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Attribute reviewChecked 18 test(s) against the attribute rubric with Fail: CISA.MS.SECURITYSUITE.1.2
Fail: CISA.MS.TEAMS.1.1
Fail: CISA.MS.TEAMS.1.2
Fail: CISA.MS.TEAMS.1.5
Fail: CISA.MS.TEAMS.2.1
Fail: CISA.MS.TEAMS.2.2
Fail: CISA.MS.TEAMS.4.1
Pass
Notes
Change the value, or explain in the pull request why the declared value fits the rubric. A maintainer can overrule this check with the |
📑 Description
Aligns Maester's CISA Teams suite with the pinned ScubaGear Teams baseline. Adds 14 native checks and their remediation guides, updates the CISA framework mappings, and adds delegated Teams unified app settings retrieval with legacy-policy fallback where appropriate.
This branch was originally stacked on #2768. Per direction, this PR targets upstream
main; since #2768's head branch exists only in the fork, the current comparison also includes the commits from #2768. The PR will need to be updated after #2768 lands to remove that overlap.No linked issue.
✅ Checks
/powershell/tests/pester.ps1locally.ℹ️ Additional Information
Validation completed:
Build-MaesterModule.ps1 -OutputRoot C:\Users\MODAdministrator\source\repos\maester-cisa-teams-baseline-alignment\.tmp-maester-teams-build-b89b08e7f3444954895a8c1794c6729a— passed; temporary build output was removed.Invoke-Pester -Path @('.\powershell\tests\functions\CisaTeamsChecks.Tests.ps1', '.\powershell\tests\functions\TeamsUnifiedSettings.Tests.ps1', '.\powershell\tests\functions\Clear-ModuleVariable.Tests.ps1', '.\powershell\tests\functions\Connect-Maester.Tests.ps1', '.\powershell\tests\functions\Disconnect-Maester.Tests.ps1', '.\powershell\tests\functions\engine\Frameworks.Tests.ps1', '.\powershell\tests\general\Build-MaesterModule.Tests.ps1') -Output Normal— passed (171 tests).git diff --cached --check— passed.The full
/powershell/tests/pester.ps1suite was not run. The repository template notes new checks submitted during the Maester 3.0 code freeze may be reviewed after release.How to Contribute
🏗️ Read our full contributing guide for the Maester project.
🧪 We also have additional instructions and a checklist for creating tests.
Join us at the Maester repository discussions or Entra Discord for more help and conversations!
While you wait for a review, why not spread some Maester love on social media? Thank you! 💖
🤖 This pull request was created with the assistance of Copilot (Copilot SDK in VS Code), directed by @JeremyFinney-lgtm.