Repository navigation
Mark SCContentSharingPicker::sharedPicker unsafe - #881
Merged
madsmtm merged 1 commit intoOct 14, 2026
Merged
Conversation
madsmtm
added
bug
Owner
|
Thanks!
I think Feedback IDs are nice because then you know that Apple at least should be aware of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed in #879, this marks the shared accessor
unsafeinstead of the racing methods.SCContentSharingPickercan only be obtained throughsharedPicker, sinceinitandneware unavailable, so every thread that calls it gets the same picker. On macOS 15.7.9, 26.6.2 and 27.0.1, racingsetDefaultConfigurationorsetMaximumStreamCounton that picker releases the old value twice and crashes inobjc_release(FB25187882, reproductions forsetDefaultConfigurationandsetMaximumStreamCount).The ScreenCaptureKit safety defaults are not released yet, so nothing changes compared to the last release and there is no changelog entry. The regenerated bindings are in the generated fork.
I included the FB25187882 in the doc which I understand is meaningless to all except Apple engineers, so I am not sure whether I should just remove it or not.