Repository navigation
Back goes to the previous song, or asks the room to - #58
Merged
Merged
Conversation
Back still restarts the song; pressed in its first 3 seconds it now plays the song before again. The interrupted song goes back to the front of the queue to play next from the start, and its unfinished play is forgotten so it isn't a skip. It takes the skip permission; in a room that votes on skips it asks the room through the play-now vote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back used to only restart the song, so there was no way to hear the last one again.
What back does now
Changes
previousplayback action.PlayNowVotegainsbackanditem, since the song isn't in the queue.00024: addsqueue_items.resume_at. Songs with it set play ahead of the fair order. Moving or removing a song clears it.previousCommand,previousandgoBack. Play-now votes can now settle as a go-back.use-room-controls, the lock-screen handler inspeaker.ts, and the vote prompt inplay-now-request.player-mode.md.Testing
TestPreviousandTestPreviousVote.go test -race ./..., golangci-lint, and the web typecheck, lint and tests all pass.🤖 Generated with Claude Code