Repository navigation
fix(games): report installers of anticheat games as not playable - #772
Merged
Merged
Conversation
Games flagged with kernel level anticheat are known not to work, but their installers were still returned by the API with is_playable set to null, so the client couldn't tell them apart. Report them as not playable. Refs #769 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #769, and is the server side of lutris/lutris#6935.
Games flagged
kernel_ac(kernel-level anticheat, e.g. League of Legends) are known not to work, and the website already shows a big warning on their page. The installers API still returned their installers withis_playable: null, the same as any unrated installer. The client therefore had no way to tell users.Installer.is_playable()now returnsFalsewhen the game has thekernel_acflag; otherwise it still returns the verified rating, as before. The installers stay in the API on purpose: the client will show them as Not playable (lutris/lutris PR to follow), rather than hiding them, so users who want to try anyway can still do so.On the game page template, this only changes the rating line of such installers to "NOT PLAYABLE". Those pages already hide the installer list behind the anticheat warning.
Tests:
TestInstallerIsPlayablecovers an unrated installer (stillNone), thekernel_acgame's installer (False), and/api/installers/<slug>returningis_playable: false. The last two fail without the fix. The full suite passes (169 tests), as doruff checkandruff format --check.🤖 Generated with Claude Code