Skip to content

Say that native builds aren't cached on Windows, and let a toolchain probe start Node there - #1209

Draft
tolgaergin wants to merge 2 commits into
feat/sandbox-node-warningfrom
fix/windows-executable-lookup
Draft

tolgaergin wants to merge 2 commits into
feat/sandbox-node-warningfrom
fix/windows-executable-lookup

Conversation

@tolgaergin

@tolgaergin tolgaergin commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Native builds are recognized, and so cached, on macOS and Linux only. On Windows the build cache said something else: it looked for Node, didn't find it, and reported that Node couldn't be fingerprinted.

Change

  • The cache says once, before it runs anything, that it covers macOS and Linux only. It no longer looks for Node on Windows for a fingerprint it can't use.
  • A toolchain probe runs with a short list of variables. On Windows a probe is now also told where Windows is (SystemRoot, windir): Node stops at startup without it. The value comes from Windows itself, not from the environment, so the variable can't send a probe's libraries elsewhere. The sandbox Node warning passed the two variables to its own probe, from the environment; it now uses the shared list.

Nothing changes on macOS or Linux, and the cache stays off on Windows.

Tests

  • A unit test for the variables a probe is given: none of the two elsewhere, and on Windows not the environment's values.
  • On Windows, Node was shown to exit at startup without SystemRoot and to run with it. The early message and the new source of the two values have not run there yet.

🤖 Generated with Claude Code

@tolgaergin
tolgaergin added this pull request to stack #1205 November 16, 2026 02:41
@tolgaergin
tolgaergin force-pushed the fix/windows-executable-lookup branch from bd561fd to a88f486 Compare November 16, 2026 05:15
@tolgaergin tolgaergin changed the title Find a command by its extension when the build cache looks for it on Windows Say that native builds aren't cached on Windows, and let a toolchain probe start Node there Nov 16, 2026
@tolgaergin
tolgaergin force-pushed the fix/windows-executable-lookup branch from a88f486 to a9915d1 Compare November 16, 2026 13:40
@tolgaergin
tolgaergin force-pushed the fix/windows-executable-lookup branch from a9915d1 to 9623d1f Compare November 16, 2026 16:10
tolgaergin and others added 2 commits November 16, 2026 18:06
…t Node there

Native builds are recognized on macOS and Linux only, so the build cache
never applied on Windows. It said so one package at a time, as a command
it didn't recognize, after it had run Node for a fingerprint it couldn't
use. It now says that once, before it runs anything.

A toolchain probe runs with a short list of variables. On Windows that
list left out the system directory, and Node stops at startup without
it, so the fingerprint was never read there. The Node warning already
passed the two variables to its own probe; every probe now gets them.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@tolgaergin
tolgaergin force-pushed the fix/windows-executable-lookup branch from 9623d1f to 60a8c73 Compare November 16, 2026 18:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant