Repository navigation
Say that native builds aren't cached on Windows, and let a toolchain probe start Node there - #1209
Draft
tolgaergin wants to merge 2 commits into
Draft
tolgaergin wants to merge 2 commits into
tolgaergin wants to merge 2 commits into
Conversation
tolgaergin
force-pushed
the
fix/windows-executable-lookup
branch
from
November 16, 2026 05:15
bd561fd to
a88f486
Compare
tolgaergin
force-pushed
the
fix/windows-executable-lookup
branch
from
November 16, 2026 13:40
a88f486 to
a9915d1
Compare
tolgaergin
force-pushed
the
fix/windows-executable-lookup
branch
from
November 16, 2026 16:10
a9915d1 to
9623d1f
Compare
…t Node there Native builds are recognized on macOS and Linux only, so the build cache never applied on Windows. It said so one package at a time, as a command it didn't recognize, after it had run Node for a fingerprint it couldn't use. It now says that once, before it runs anything. A toolchain probe runs with a short list of variables. On Windows that list left out the system directory, and Node stops at startup without it, so the fingerprint was never read there. The Node warning already passed the two variables to its own probe; every probe now gets them. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
tolgaergin
force-pushed
the
fix/windows-executable-lookup
branch
from
November 16, 2026 18:13
9623d1f to
60a8c73
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native builds are recognized, and so cached, on macOS and Linux only. On Windows the build cache said something else: it looked for Node, didn't find it, and reported that Node couldn't be fingerprinted.
Change
SystemRoot,windir): Node stops at startup without it. The value comes from Windows itself, not from the environment, so the variable can't send a probe's libraries elsewhere. The sandbox Node warning passed the two variables to its own probe, from the environment; it now uses the shared list.Nothing changes on macOS or Linux, and the cache stays off on Windows.
Tests
SystemRootand to run with it. The early message and the new source of the two values have not run there yet.🤖 Generated with Claude Code