Skip to content

test(todo): validate managed claim references at the native owner #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopx-agent merged 1 commit into from
Oct 28, 2026
+32 −1
Merged

test(todo): validate managed claim references at the native owner #7572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/control_plane/test_todo_claim_argument_recovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,22 @@ def test_ordinary_claim_progress_completion_need_no_lease_flags(claim_cli):
replay = run([*prefix, "todo", "complete", *common, "--evidence", "evidence:validated-output"])
assert replay["ok"] is True
assert snapshot() == before


@pytest.mark.parametrize("command", ["update", "complete"])
def test_empty_managed_reference_is_rejected_without_mutation(claim_cli, command):
_, run, snapshot, prefix, claim, _, _, _ = claim_cli
accepted = run([*prefix, *claim, "--claimed-by", "peer-a",
"--claim-operation-id", "valid-managed-reference"])
assert accepted["ok"] and accepted["execution_managed"]
before = snapshot()
arguments = [*prefix, "todo", command, "--goal-id", GOAL, "--todo-id", TODO,
"--agent-id", "peer-a", "--claim-operation-id", ""]
arguments += (["--note", "Only a valid original execution may update this task."]
if command == "update" else ["--evidence", "evidence:validated-output"])
rejected = run(arguments, expected_exit=1)
assert rejected["error_code"] == (
"invalid_local_coordination_todo_update_request" if command == "update"
else "invalid_local_coordination_todo_terminal_lifecycle_request")
assert rejected["error"] == "claim_operation_id must be a non-empty trimmed string"
assert snapshot() == before
14 changes: 13 additions & 1 deletion tests/test_cli_argument_diagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ def test_todo_claim_validation_preserves_exact_diagnostics(
assert str(exc_info.value) == expected


@pytest.mark.parametrize("command", ["add", "list", "update", "complete", "supersede"])
@pytest.mark.parametrize("command", ["add", "list", "supersede"])
@pytest.mark.parametrize("operation_id", ["retry-one", ""])
def test_claim_operation_id_is_not_silently_ignored_by_other_commands(command, operation_id):
args = build_parser().parse_args([
Expand All @@ -567,6 +567,18 @@ def test_claim_operation_id_is_not_silently_ignored_by_other_commands(command, o
validate_shared_todo_options(args)


@pytest.mark.parametrize("command", ["update", "complete"])
@pytest.mark.parametrize("operation_id", ["retry-one", ""])
def test_managed_claim_reference_is_retained_for_the_execution_owner(command, operation_id):
args = build_parser().parse_args([
"todo", command, "--goal-id", "example-goal", "--claim-operation-id", operation_id,
])
validate_shared_todo_options(args)
# Scope validation admits the supported caller without dropping its raw
# reference. The native owner still rejects an invalid empty value.
assert args.claim_operation_id == operation_id


@pytest.mark.parametrize(
("extra_args", "expected"),
[
Expand Down
Loading