Repository navigation
Close the readback and numa-degrade issues; record both outcomes - #3520
Merged
Merged
Conversation
Both rows landed 2026-10-29: the readback levers as 90fe546 (PR localai-org#3517) and the NUMA interleave degrade as db1d71c (PR localai-org#3519). Each issue closes with dated resolution evidence and each spec gains its ## Outcome: what was measured, what the review's mutations proved (the tautology finding; the load-bearing active_ flag; the doctest 2.5.2 SUBCASE sibling-loss), and what stays open (the absolute anchoring and first green device-golden under the kolibri-1-tenstorrent row; the stderr-count gate candidate; the env-doc semantics-drift characterization). FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:zai/glm-5-3-flash [maki]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the readback and numa-degrade issues; record both outcomes
Both rows landed 2026-10-29: the readback levers as 90fe546 (PR #3517)
and the NUMA interleave degrade as db1d71c (PR #3519). Each issue
closes with dated resolution evidence and each spec gains its ## Outcome.
The readback outcome records what was measured (3358.1 -> 3184.6
ms/step, -5.2% same-session A/B, byte-identical chains 3/3 per arm)
and what the review's mutations proved — above all that the old
fill-time verify was a tautology and the Record-before-enqueue ordering
is the first genuine device-vs-host compare on this path. The numa
outcome records the three-valued knob, the identical assertion counts
under forced fallback, the load-bearing active_ flag (a restoring dtor
would write policy from knob-off inert guards), and the doctest 2.5.2
SUBCASE sibling-loss finding that shaped the test split.
Left open and named: the absolute anchoring (548 vs 3358 ms/step) and
the first green device-golden record, owed under the kolibri-1
-tenstorrent row; the stderr-count gate candidate for the fallback
warning; the env-doc semantics-drift characterization (the checker
enforces presence, review enforces meaning).
FOLLOWING_AGENTS_PROTOCOL
Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:zai/glm-5-3-flash [maki]