Repository navigation
Conversation
lissy93
left a comment
lissy93
left a comment
There was a problem hiding this comment.
Thanks @KeuqS,
But I'm curious, how did you encounter this issue? Since I don't think I ever finished the multi-lang support, so there really isn't any language switching functionality for most languages.
Though yeah, the ordering bug does look real. But I don't think this PR will fix it though. TranslationService only gets created when something injects it, and language is actually set by languageInitializerFactory in translation-loader.factory.ts, and this function which only reads localStorage and ignores the URL. From testing this, the language switching happens only when the menu gets opened.
This comment was marked as outdated.
This comment was marked as outdated.
lissy93
changed the title
|
Hi lissy93, I want to clarify that @KeuqS is operated by me, a real person, not an unattended automated bot. I put genuine time and effort into preparing this change because I was trying to help the project. I am sorry that my good-faith attempt to help caused frustration and extra work for you and the project. I am genuinely unhappy that an effort made with good intentions led to this situation. After this experience, I am stepping away from helping public repositories and will not submit further PRs or credit requests. I will not ask you to reopen or review this PR. Thank you for the feedback. |
Thanks @KeuqS for your reply. But when you are submitting a PR every 4-6 minutes for 3 days strait (with no previous GitHub activity), then there is no chance that there was even a human-in-the-loop. Take this PR for example, this fixes a bug which is impossible for any real user to land on (since multi-lang support is not enabled yet). That said, your first PR to Dashy (lissy93/dashy#2384) did seem genuine, and I was happy to review and merge it. |
|
Thank you for explaining your concerns. I would like to clarify that I am not a bot and that I personally put effort into each change I submitted. I recently left my job at a software company. Until the last four or five days, I had very little GitHub activity, but during this period of unemployment I started focusing much more on GitHub and software development. I spend a large part of my day at my computer. According to my local time zone, I usually sleep around midday and spend most of the rest of the day reviewing projects, improving my skills, and trying to be useful to others. I genuinely worked on each PR I submitted. I may have misjudged whether some suggestions were necessary or realistic for the project, but they were not meaningless submissions intended to collect likes or attention. My goal was to improve my skills, contribute to open-source projects, and help wherever I could. I am sorry that the volume and frequency of my activity created the impression that my account was operated by a bot. I understand why it raised concerns and I take your feedback seriously. However, there is a real person behind this account, and I made these contributions in good faith and with genuine effort. |
Thanks for tracing this in detail. To answer your question directly, I did not encounter this through a working end-user language-switching flow. I came across the URL and localization-related code while reviewing the project and incorrectly inferred that URL-based language selection was already part of the supported flow. I should have verified the feature鈥檚 actual availability and the complete initialization path before opening the PR. You are right that TranslationService is only created when it is injected, and that the language is initialized by languageInitializerFactory in translation-loader.factory.ts, which currently ignores the URL. Therefore, my PR does not fix the behavior you described. |
|
Well, then you must just be super-human then. Being able to work across 300 projects, with 12 different programming languages, submitting 1 PR every 20 seconds to 10 minutes, with bugs no human could ever find. 
Source: https://goard.as93.net/ |
Thanks for the advise, it appeared as notice in the pr in my lib hehehe Regards |
3 participants
No description provided.