Repository navigation
fix(wallpaperslideshow): unbreak home dir test - #209
Merged
deepin-bot[bot] merged 1 commit intoOct 30, 2026
Merged
deepin-bot[bot] merged 1 commit into
deepin-bot[bot] merged 1 commit into
Conversation
1. CI builds run under pbuilder with HOME=/nonexistent, so the value returned by GetUserHomeDir() is not an existing directory. 2. Compare it with QDir::homePath() instead of asserting the directory exists. 3. Keep the non-empty contract while staying valid in any build chroot. Log: Make the home directory test independent of whether HOME exists. Influence: dde-services builds pass in pbuilder chroots again. fix(wallpaperslideshow): 修复家目录测试在构建 chroot 中失败 1. CI 在 pbuilder 下以 HOME=/nonexistent 构建,GetUserHomeDir() 返回的家目录 并不存在。 2. 改为与 QDir::homePath() 比较,不再断言目录真实存在。 3. 保留非空契约,使测试在任何构建 chroot 中都成立。 Log: 家目录测试不再依赖 HOME 指向的目录存在。 Influence: dde-services 在 pbuilder 构建环境中恢复通过。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the wallpaper slideshow home-directory test to validate path mapping rather than directory existence, allowing builds to pass in pbuilder chroots where HOME may reference a nonexistent path. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
approved these changes
Oct 30, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Make the home directory test independent of whether HOME exists.
Influence: dde-services builds pass in pbuilder chroots again.
fix(wallpaperslideshow): 修复家目录测试在构建 chroot 中失败
Log: 家目录测试不再依赖 HOME 指向的目录存在。
Influence: dde-services 在 pbuilder 构建环境中恢复通过。
Summary by Sourcery
Make the home-directory test independent of whether the configured HOME path exists.
Bug Fixes:
Enhancements: