Skip to content

fix(wallpaperslideshow): unbreak home dir test - #209

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fix/wallpaperslideshow-home-test
Oct 30, 2026
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fix/wallpaperslideshow-home-test

Conversation

@MyLeeJiEun

@MyLeeJiEun MyLeeJiEun commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
  1. CI builds run under pbuilder with HOME=/nonexistent, so the value returned by GetUserHomeDir() is not an existing directory.
  2. Compare it with QDir::homePath() instead of asserting the directory exists.
  3. Keep the non-empty contract while staying valid in any build chroot.

Log: Make the home directory test independent of whether HOME exists.
Influence: dde-services builds pass in pbuilder chroots again.

fix(wallpaperslideshow): 修复家目录测试在构建 chroot 中失败

  1. CI 在 pbuilder 下以 HOME=/nonexistent 构建,GetUserHomeDir() 返回的家目录 并不存在。
  2. 改为与 QDir::homePath() 比较,不再断言目录真实存在。
  3. 保留非空契约,使测试在任何构建 chroot 中都成立。

Log: 家目录测试不再依赖 HOME 指向的目录存在。
Influence: dde-services 在 pbuilder 构建环境中恢复通过。

Summary by Sourcery

Make the home-directory test independent of whether the configured HOME path exists.

Bug Fixes:

  • Make the wallpaper slideshow home-directory test pass in build chroots where HOME points to a non-existent path.

Enhancements:

  • Validate the helper’s home-directory mapping against Qt’s resolved home path while retaining the non-empty check.

1. CI builds run under pbuilder with HOME=/nonexistent, so the value returned
   by GetUserHomeDir() is not an existing directory.
2. Compare it with QDir::homePath() instead of asserting the directory exists.
3. Keep the non-empty contract while staying valid in any build chroot.

Log: Make the home directory test independent of whether HOME exists.
Influence: dde-services builds pass in pbuilder chroots again.

fix(wallpaperslideshow): 修复家目录测试在构建 chroot 中失败

1. CI 在 pbuilder 下以 HOME=/nonexistent 构建,GetUserHomeDir() 返回的家目录
   并不存在。
2. 改为与 QDir::homePath() 比较,不再断言目录真实存在。
3. 保留非空契约,使测试在任何构建 chroot 中都成立。

Log: 家目录测试不再依赖 HOME 指向的目录存在。
Influence: dde-services 在 pbuilder 构建环境中恢复通过。
@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the wallpaper slideshow home-directory test to validate path mapping rather than directory existence, allowing builds to pass in pbuilder chroots where HOME may reference a nonexistent path.

File-Level Changes

Change Details Files
Make the user-home utility test independent of the physical existence of the configured home directory.
  • Continue asserting that the returned path is non-empty.
  • Compare the helper result with Qt’s normalized home path instead of checking filesystem directory existence.
  • Document compatibility with pbuilder environments using HOME=/nonexistent.
src/plugin-qt/wallpaperslideshow/tests/tst_wpssl_utils.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy

mhduiy commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot

deepin-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 5db98bd into linuxdeepin:master Oct 30, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants