Skip to content

test: scratch probe - does the App token make the updated head's checks run? - #3699

Closed
eleshar wants to merge 2 commits into
developfrom
ci/scratch-app-token-probe
Closed

eleshar wants to merge 2 commits into
developfrom
ci/scratch-app-token-probe

Conversation

@eleshar

@eleshar eleshar commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Scratch branch to settle the follow-up to #3693: whether updating a branch with the bot App token (instead of GITHUB_TOKEN) makes the new head's pull_request checks actually run.

The GITHUB_TOKEN variant was already measured twice on #3698: each updated head had ten pull_request runs all action_required and zero check runs. This repeats the experiment with BOT_PR_APP_CLIENT_ID / BOT_PR_APP_PRIVATE_KEY, the same App documentation.yml already uses.

Branch is 1 commit behind develop and mergeable. Not for merge; will be closed and deleted.

Labels: type:ci, area:ci, priority:minor, status:needs-review.

Linked issues

Relates to #3693, #3574

Checklist (Global DoD / PR)

  • All AC met and demonstrated — n/a, test branch
  • Tests added/updated — n/a, test branch
  • Code/design reviews approved — do not review
  • CI green — n/a, test branch

Summary by CodeRabbit

  • New Features
    • Pull requests targeting develop are automatically checked for updates when develop changes and when a pull request is opened, reopened, or marked ready for review.
    • Eligible pull requests are updated from develop. When an update cannot be merged because of conflicts, a comment summarizes the conflict; other update outcomes are reported in the workflow summary.

@github-actions

Copy link
Copy Markdown
Contributor

AI Feedback Validation Report

❌ No issue link found: the PR must include Resolves #123 or Closes #123.

Required actions

  1. Link this PR to its issue with Resolves #123 or Closes #123 in the description.
  2. Track AI review feedback in FEEDBACK_RESPONSE.md with a status per item.
  3. For deferred feedback, open a follow-up issue and link it.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lightspeedwp/.github/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: f15f466e-8ad5-48df-adac-dc9b5d315ddb

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1021e and 9549047.

📒 Files selected for processing (3)
  • .github/workflows/keep-pr-current.yml
  • docs/BRANCHING_STRATEGY.md
  • scripts/automation/keep-pr-current.cjs
 _________________________________________________________________________________________
< The three laws of code review: 1. Find bugs. 2. Find more bugs. 3. Find even more bugs. >
 -----------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eleshar eleshar closed this Sep 30, 2026
@eleshar
eleshar force-pushed the ci/scratch-app-token-probe branch from 9549047 to 2ad4125 Compare September 30, 2026 15:56
@eleshar eleshar reopened this Sep 30, 2026
@eleshar

eleshar commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Scratch probe for #3693, closing and deleting as planned. Results recorded on #3693.

@eleshar eleshar closed this Sep 30, 2026
@eleshar
eleshar deleted the ci/scratch-app-token-probe branch September 30, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant