chore: remove compounded footer blocks, batch 26 of 45 (#3451) - #3645
Merged
Merged
Conversation
Refs #3451 Batch 26 of 45. Pure deletion: 90 files, 0 added. node scripts/dedupe-footers.js --fix --paths-from=small-26.txt The scope split comes from the code, not per-file judgement: isFooterExemptPath() in scripts/agents/includes/footer-policy.js with the keep decision in analyseContent(). 66 of the 90 files are footer-exempt and lost their footer entirely, which is the policy docs/QUIRKY_FOOTERS_GUIDE.md states; the other 24 were collapsed to exactly one clean trailing footer, the last block, which is what ensureFooter() treats as canonical. Covers `skills/tour-operator-website`. Manifests were derived once before any of this ran and are fixed: batch N is small-NN.txt. Cross-batch overlap is 0, so these pull requests cannot conflict with each other. Verification: - re-running --check over the manifest reports 0/90 affected - independent differential pass, negative-tested: pure order-preserving deletion, every deleted line classified as footer structure, none from frontmatter or a fenced code block, and the classified counts sum to exactly the numstat deletion total - staged paths match the manifest exactly, 0 outside No changelog entry: Markdown-only diff, exempt as docs-only by the gate in changelog-unified.yml. The pre-commit hook is bypassed for this commit, as in every commit in this series. It runs npx lint-staged, dependencies are not installed in this worktree, and #3590 records that the Markdown hook corrupts shields.io badge links. CI does not run lint:md, so this does not diverge from what CI checks.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Contributor
|
No description provided. |
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lightspeedwp/.github/.coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (90)
💤 Files with no reviewable changes (90)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis change removes repeated attribution, documentation-signature, contributor-link, and GitHub-contact footer text from Markdown documents in three skill collections. Some documents retain one footer copy. ChangesDocumentation footer cleanup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The changes are limited to footer cleanup, with no identified content loss or merge-blocking issue. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
area:theme
Contributor
PR Template RoutingBranch Type: This PR was automatically routed based on the branch naming strategy. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compounded footer blocks removed — batch 26 of 45
Refs #3451 — not
Closes. The issue stays open until all 45 batches land and the whole-repo run reports zero.Linked issues
Relates to #3451— repo-wide footer duplicate cleanup. 19 batches remain after this one.Why 90 files and not 1,950
CodeRabbit's server-side review only runs under 100 changed files. Every batch of the earlier plan was skipped with
Review skipped: … files exceed the limit of 100, so their review was a local slice rather than a review of the pull request. Batches are capped at 90, leaving headroom forCHANGELOG.mdand keeping the largest pull request at 91 files. The cost is explicit: 45 pull requests.Context
Reproduction
Scoped to this batch's manifest, so the check reports only what this pull request changed:
Before the fix:
90/90 file(s) affected · blocks found 502 · exempt-path files 66, exit 1.After the fix:
0/90 file(s) affected, exit 0.Root Cause
Two defects, both fixed in merged tooling:
header-footer.jsheldFOOTER_PATTERNSprivately, so the end-anchored matcher inensureFooter()could not see an asterisk-wrapped footer. Every automation run appended another copy rather than replacing the existing one, compounding the stack. Fixed by fix: match asterisk-wrapped footers in dedup regex #3443 and feat: add footer duplicate guard and share footer policy (#3451) #3588.docs/QUIRKY_FOOTERS_GUIDE.mdwas documented and mirrored into two config files, but no live code read either. Fixed by feat: add footer duplicate guard and share footer policy (#3451) #3588.Fix Summary
Deletion only, produced by the committed tool over this batch's fixed manifest:
The split is decided by
isFooterExemptPath()inscripts/agents/includes/footer-policy.jsand thekeepdecision inanalyseContent(), not by a judgement call per file. Batch 26 coversskills/tour-operator-website.Verification
--checkover the manifest after the fix reports0/90 file(s) affected, exit 0 — idempotent.numstatdeletion total, a second independent count of the same number. The checker is negative-tested — an injected content line and a deletion from inside a fence both make it fail.CodeRabbit
CodeRabbit ran and raised NO findings.
Read from the bot's own comment, not the check summary line: on at least one
batch the check read "Review completed" while the comment was a rate-limit
warning, so the comment is the authoritative source.
A green tick on this check does not by itself mean reviewed — the check also
passes when CodeRabbit declines. The line above states which happened here.
Changelog
None. This is a Markdown-only diff, which the
changelog-unified.ymlgate exempts as docs-only. Theskills/area-level entry lands on the last pull request for that area.Risk & Rollback
git revertthis commit. The revert is itself a pure insertion.npx lint-staged, dependencies are not installed in the worktree used for this work, and fix: lint:md and lint-staged corrupt shields.io badge links whose URL contains a space #3590 records that the Markdown hook corrupts shields.io badge links. CI does not runlint:md.