Skip to content

docs: sync exchangeRate examples with schema change - #1076

Open
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260925
Open

claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260925

Conversation

@claude

@claude claude Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add new exchangeRate field to receiver lookup examples in limits.mdx and uma.mdx
  • Add tip explaining the difference between estimatedExchangeRate (receiving/sending) and exchangeRate (sending/receiving, same as quotes)

Syncs documentation examples with the schema change from #1067 (Add exchangeRate to receiver lookup currency preferences).

What changed

Docs:

  • mintlify/snippets/sending/limits.mdx: Added exchangeRate: 0.054 to external account lookup example, added explanatory tip
  • mintlify/snippets/sending/uma.mdx: Added exchangeRate to EUR (1.087) and BRL (0.194) entries in UMA lookup example

No changes needed:

  • Kotlin sample: Consumes API responses, no hardcoded CurrencyPreference fields
  • Grid Visualizer: No references to receiver lookup response fields

🤖 Generated with Claude Code

Update snippet examples to include the new exchangeRate field on
CurrencyPreference (from #1067). Add a tip explaining the difference
between estimatedExchangeRate and exchangeRate - the latter matches
the quote's direction for direct comparison.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Sep 25, 2026 8:19am UTC
grid-flow-builder Ignored Ignored Sep 25, 2026 8:19am UTC
grid-wallet-demo Ignored Ignored Sep 25, 2026 8:19am UTC

Request Review

@mintlify

mintlify Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Sep 25, 2026, 8:20 AM

@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low risk] Updates API documentation examples to match schema.

The PR appears safe to merge, though the conflicting quote example should be reconciled to keep the new guidance usable.

Findings

  1. P2 Conflicting quote rate direction ▶
Fix with agent prompt
### Issue 1
mintlify/snippets/sending/limits.mdx:115-117
The send-payment page displays this tip immediately before a USD-to-EUR quote example with `exchangeRate: 0.92`-EUR per USD, the opposite direction from the tip. Readers of that page cannot compare the lookup and quote rates as instructed without first resolving which quote example is correct. Please reconcile the example with the documented rate direction.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR adds exchangeRate to external-account and UMA receiver-lookup examples and explains its direction relative to estimatedExchangeRate.

  • The added values are consistent with the displayed estimates.
  • The new comparison guidance conflicts with a quote example on a page that displays the snippet.

Reviews (1) · Last reviewed commit: "docs: add exchangeRate to receiver looku..."

Comment on lines +115 to +117
`estimatedExchangeRate` is receiving currency per sending currency. `exchangeRate` is the
inverse — sending currency per receiving currency — matching the direction of `exchangeRate`
on a quote, so you can compare lookup estimates to actual quotes directly without inverting.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Conflicting quote rate direction The send-payment page displays this tip immediately before a USD-to-EUR quote example with exchangeRate: 0.92—EUR per USD, the opposite direction from the tip. Readers of that page cannot compare the lookup and quote rates as instructed without first resolving which quote example is correct. Please reconcile the example with the documented rate direction.

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/limits.mdx
Line: 115-117

Comment:
**Conflicting quote rate direction** The send-payment page displays this tip immediately before a USD-to-EUR quote example with `exchangeRate: 0.92`—EUR per USD, the opposite direction from the tip. Readers of that page cannot compare the lookup and quote rates as instructed without first resolving which quote example is correct. Please reconcile the example with the documented rate direction.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

This branch was successfully deployed

1 active deployment
staging - mintlify — f436f826 Deployed Sep 25, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants