Fix several open issues about core and guide pages - #1207
Merged
Merged
Conversation
The core searches the WAD's folder, then system/prboom/, then the system directory, for music as for prboom.wad and other WAD and DEH files. The page only mentioned the game folder, which was reported not to work on tvOS; system/prboom/ does. Fixes libretro#1163.
The core also looks in system/fbneo/patched/ first when patched romsets are allowed. system/fbneo/ is searched on every platform, next to the samples and hiscore files, so recommend it rather than making it look Android-specific. Addresses libretro#1130.
The nav entry named library/3d_engine.md, which does not exist, so the 3D Engine page could not be reached from the menu.
The page linked standalone Citra's user directory (AppData/Roaming/Citra and the like), so dumped system files were put where the core does not look. By default the core keeps sysdata, nand, sdmc and the shader cache in saves/Citra/; standalone's directory is only used with Savegame location set to Citra Default. Fixes libretro#598.
- The core options list the 59 options of the current core in its seven categories, SMC check included; 24 listed options no longer exist. - Netplay works (with the host's memory card). - Multitap is one Multitap Mode option now, not Multitap 1 and 2, and a tip says to disable it when a game's controls do not respond. - Rumble points at the option's current name, Rumble Effects. Fixes libretro#612, fixes libretro#1115, fixes libretro#561.
The Accuracy, Balanced and Performance pages were bsnes_accuracy.md and so on, but the cores are bsnes2014_accuracy and the rest - the v094 bsnes kept next to the current one - so nothing linked the two and readers looked for cores that are not on the buildbot. The pages are renamed to bsnes2014_*.md, titled bsnes 2014, say which core file they are about and point at the current bsnes page; the nav, core list and every link to them follow, and the info file links point at libretro-core-info. Fixes libretro#1195, addresses libretro#958.
The page repeated three times that a Portal is not a gaming device and still carried a chatbot's "Sure! Here's a step-by-step guide". It now says why RetroArch runs in the browser there and lists the four steps. Fixes libretro#893.
Azahar, the Citra-based 3DS core, is on the buildbot but had no page. It takes background, authors, extensions and feature support from the core's info file, and the 32 core options in their seven categories from the core's source. Like Citra it keeps system files and saves in its own user directory, saves/Azahar/, which the page says. It is added to the nav next to Citra and to the core list. Fixes libretro#1157.
Cores are named <name>_libretro and match <name>_libretro.info. The _android/_ios/_tvos suffix some builds carry is optional: RetroArch drops the last underscore-separated part unless it is _libretro, so a core without one matches its info file just the same. Say so, so that a missing suffix stops being reported as a bug. Fixes libretro#1176.
The core also finds a bios in the system directory itself, but its info file lists every bios as fbneo/<name>.zip, so RetroArch's core information and firmware check call one there missing. That is what made the fbneo subfolder look mandatory; say so and recommend it on every platform. Fixes libretro#1130.
The page listed the Model core option and the path tags but not how to use either, so it was unclear how to run one game as an A1200. It now gives the three ways - the option for every game, the option saved as a game override, and a tag in the file or folder name - notes that the model changes when the core restarts and needs that model's Kickstart ROM, and says what passing a .uae file means: loading it as content. Fixes libretro#1096.
With Light Gun Input set to Touchscreen the gun aims at the touch and every touch pulls the trigger; two, three and four fingers add B, Start and C. The page did not say so, nor that the touchscreen feeds the light gun's port while the on-screen gamepad feeds User 1. Point at RetroArch's overlay light gun and its Lightgun Port for games that need a gun and a pad. Addresses libretro#1057.
The page said you could supply your own microphone sample and that this "may not work". The core has no way to load a sample file, and its physical mode returns silence (still a TODO in mic.cpp), so both settings leave the microphone silent. Say so and point at internal and random. Fixes libretro#605.
- The saturn.png and dc.png pictures showed an old mapping (Saturn A, B, C on RetroPad Y, B, A; Dreamcast triggers on the shoulders). The cores map A, B, C to B, A, R1 and put the Dreamcast triggers on L2/R2, and the tables under the pictures already say so, so the pictures are removed rather than contradicting them. - Yabause and Kronos: C is R1 and Z is L1, as in Beetle Saturn; the tables had them swapped. - Flycast: the Dreamcast pad's L and R triggers are L2 and R2; the table listed fierce/weak L and R on L1/R1 and L2/R2. - Redream: Y is RetroPad X, not A (A was listed twice). Fixes libretro#1029.
Each keeps an XML DAT of the romsets it expects in its metadata directory; link it from the page, as the FBNeo page links its dats (libretro#384). Addresses libretro#394.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit per page, each checked against the core's current source or build.
system/prboom/, then the system directory. The page only mentioned the game folder, which was reported not to work on tvOS. Fixes PrBoom music path incorrect for TVos deployment (Apple RetroArch) #1163.system/fbneo/patched/when patched romsets are allowed, andsystem/fbneo/is recommended on every platform. The core also finds a bios in the system directory itself, but its info file lists every bios asfbneo/<name>.zip, so RetroArch's core information and firmware check report one there as missing. That is what made the subfolder look mandatory. Fixes Update FBNeo BIOS location #1130.saves/Citra/by default, not in standalone Citra's user directory the page linked. Fixes Citra - Directories Instruction #598.bsnes2014_*.mdafter the cores they describe (as suggested in bsnes 2014 Accuracy, bsnes 2014 Balanced, and bsnes 2014 Performance #1195). They are titled bsnes 2014, say which core file they are about and point at the current bsnes page. All links, the nav and the core list follow. Fixes bsnes 2014 Accuracy, bsnes 2014 Balanced, and bsnes 2014 Performance #1195, addresses Confusing/missing documentation on bsnes cores #958.library/3d_engine.md, which does not exist. They now linklibrary/3dengine.md.saves/Azahar/). It is added to the nav next to Citra and to the core list. Fixes No core page for the Azahar core #1157._android/_ios/_tvossuffix is optional, because RetroArch drops the last underscore-separated part unless it is_libretro(core_info_get_file_idin core_info.c), so a core without one matches its info file just the same. Fixes Document convention for optional OS suffixes in core filenames #1176.(A1200)or anAGAfolder. It also says that the model changes when the core restarts and needs that model's Kickstart ROM, and that passing a.uaefile means loading it as content. Fixes More clear documentation on how to change models #1096.mic.cpp), so the page says so instead of "may not work". Fixes Desmume 2015 Mic Sample #605.saturn.pnganddc.pngpictures showed an old default mapping and contradicted the tables under them, so they are removed. Yabause and Kronos had C and Z swapped (the cores map C to R1 and Z to L1, like Beetle Saturn). Flycast's Dreamcast pad has its L/R triggers on L2/R2, not L1/R1. On Redream, Y is RetroPad X (A was listed twice). Fixes Default RetroPad mapping for Saturn cores #1029.metadatadirectory, as the FBNeo page does. MAME 2015 and 2016 keep none, so they are left as they are. Addresses add DAT links for the various MAME cores #394.The Dolphin page lost the PPSSPP text reported in #601 (the
ppsspp_*core options and the PSP controller picture) in #725, in April 2022, but that PR did not reference the issue, so it stayed open. Merging this closes it: fixes #601.The spell check on this PR fails until #1206 is merged. The failure comes from two words already on master, not from these changes.