Repository navigation
feat: share the statement runner and query result across features - #103
Merged
Merged
Conversation
Move QueryResult, QueryWarning, QueryPage, QueryPagination and newQueryId to lib/shared/models, add VectorColumn and QueryResult.vectorColumns, and add IStatementRepository with StatementRepository (POST /db/query) in lib/infrastructure/studio, which SqlEditorRepository.run now delegates to. A run sends database only when set, as a JSON number, and runScript sends a page as options. The query reader reads pagination, wasLimited, warnings and openTransaction strictly in every reader that builds a QueryResult, script statements and transaction runs included. appendResultPage ports Studio's Load more rule with its unit cases.
A pagination without wasLimited now fails the read, since Studio always sends it and a missing one would hide a bound. StatementRepository.run throws an ArgumentError for a negative database before sending, as Studio refuses it with a 400. appendResultPage says why it tests isNotEmpty where Studio uses ??.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the query models and newQueryId to lib/shared/models and adds IStatementRepository with StatementRepository, so the object browser can run a statement without importing the SQL editor. SqlEditorRepository.run delegates to it, so the app has one /db/query call.
Local: format 0 changed, analyze clean, 3081 tests pass, l10n no diff.
Closes #92