Skip to content

[fork-CI] [20.0][MIG] document_page_product: Migration to 20.0 - #18

Open
dnplkndll wants to merge 14 commits into
20.0from
20.0-mig-document_page_product
Open

dnplkndll wants to merge 14 commits into
20.0from
20.0-mig-document_page_product

Conversation

@dnplkndll

Copy link
Copy Markdown

Port of document_page_product from 19.0 (OCA/knowledge#632, unmerged) to 20.0. Follows the OCA migration guide.

Depends on #16 (document_page has no 20.0 wheel yet), so Detect unreleased dependencies is expected red.

Non-mechanical adaptations worth flagging

  • BaseCommon runs tests as an independent base.group_user in 20.0, rebinding cls.env to that user. document_page grants an employee read-only on document.page, so test_page_count's write failed with AccessError. Fixed by declaring the permission the test genuinely needs — _test_user_groups = ("base.group_user", "document_page.group_document_editor") — rather than reaching for sudo(). No ACL was widened.
  • FontAwesome is gone, so the three button-box icon="fa-*" attributes become Material Symbols names (fa-tag → label, fa-book → book).

Verified: installs on a 20.0 runtime in an isolated addons dir, 3/3 Python tests pass, pre-commit clean.

AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.

victoralmau and others added 11 commits October 1, 2026 13:28
TT61666

[UPD] Update document_page_product.pot

[BOT] post-merge updates
Currently translated at 100.0% (10 of 10 strings)

Translation: knowledge-18.0/knowledge-18.0-document_page_product
Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_product/it/
Currently translated at 100.0% (10 of 10 strings)

Translation: knowledge-18.0/knowledge-18.0-document_page_product
Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_product/es/
Currently translated at 100.0% (10 of 10 strings)

Translation: knowledge-18.0/knowledge-18.0-document_page_product
Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_product/sl/
Currently translated at 100.0% (10 of 10 strings)

Translation: knowledge-18.0/knowledge-18.0-document_page_product
Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_product/fr/
- 20.0 dropped FontAwesome, so the three button-box `icon="fa-*"` attributes
  become Material Symbols names (`fa-tag` -> `label`, `fa-book` -> `book`).
- `BaseCommon` now runs tests as an independent `base.group_user`, which
  document_page grants read-only, so the test declares the editor group it
  needs via `_test_user_groups`.

Assisted-by: Claude Opus 5
@dnplkndll
dnplkndll force-pushed the 20.0-mig-document_page_product branch from 1950389 to 8ad9382 Compare October 1, 2026 18:00
@dnplkndll
dnplkndll force-pushed the 20.0-mig-document_page_product branch from 8ad9382 to d104703 Compare October 1, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants