Repository navigation
fix: review follow-ups for config safety, fan fail-safety, and CLI polish - #27
Open
harryisfish wants to merge 1 commit into
Open
harryisfish wants to merge 1 commit into
harryisfish wants to merge 1 commit into
Conversation
…lity Config: 0600 permissions, follow symlinks, patch only daemon-owned keys so comments/unknown keys/alert and curve tables survive (with TOML escaping), reject unloadable output, drop dead magsafe_led, dedupe duplicate alert rule names. Fans: fail-safe startup reconciliation for unreadable state, skip the mode write when already manual, and back off failed manual operations instead of re-entering the FTST retry loop every tick. Implement SIGKILL escalation for alert exec timeouts and dedupe repeated daemon errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 0.2.4 review. Config is written 0600, symlinks are followed, and only daemon-owned keys are patched in place so comments/unknown keys/alert and curve tables survive. Fan startup reconciliation fails safe on unreadable state, per-fan auto under a curve is rejected, and failed manual operations back off instead of re-entering the FTST loop every tick. Adds version-skew advice that does not downgrade a newer daemon, display filtering/scaling, daemon reload/capabilities, a refreshed man page, and tests.