Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58.
visitedExprswas keyed byExprusing its defaultBEqinstance, which is alpha-equivalence and ignores binder names and binder info. An expression could therefore reuse the index of an alpha-equivalent expression exported earlier. This made the exported binder names and binder info depend on which declarations had already been exported.This change introduces a small
ExprKeywrapper whoseBEqisExpr.equal(structural equality), and uses it for the expression cache.Expr.hashis still used for hashing; structural equality implies alpha-equivalence, so the existing hash remains compatible.The regression test exports two lambda expressions that differ only in binder name and binder info. On the old code the second expression reuses the first index and is not emitted; with this change both expressions are emitted with their own indices.
This can slightly increase export size because alpha-equivalent copies are no longer deduplicated, but it makes each declaration's export independent of export order.
Validation:
lake buildpasses.lake testpasses onleanprover/lean4:v4.36.0-rc1.functionWithLetlinter warning is unchanged.