Repository navigation
Seed last_finished post-provenance and keep restart contract events valid - #382
Merged
Merged
Conversation
…alid The producer suite still failed on main after #380: - Telemetry is attached after provenance, so the constructor's disk seed of last_finished found no reporter and did nothing. last_finished read null after every restart, in production too. attach_post_provenance now seeds the reporter it receives. - next_issue_claimed fires at the priority boundary, before the checkpoint names an Attempt, so it projected a claim_opened with no attempt_id. That broke the schema for every later snapshot. An attempt-scoped event with no Attempt ID now stays native.<name>. - stop_plan.remaining is the plan's requested N, as the suite and the reference stub-producer read it; only counted advances. Fixes #381 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381. Three failures in the
producerjob onmaincame out after #380.Changes
last_finishedsurvives a restart (lifecycle.py).attach_post_provenancenow seeds the reporter it receives. Before, the seed ran in the constructor when telemetry was stillNone, so it did nothing. This also hit production.claim_openedwithoutattempt_id(contract_events.py).next_issue_claimedfires before the checkpoint exists. An attempt-scoped event (claim_opened,phase_changed,outcome_recorded,attempt_finished,attempt_released,sealed) with no Attempt ID now staysnative.<name>. The Claim still opens once, atissue_claimed.stop_plan.remaining= requested N (contract_status.py). This matches the suite and the reference stub-producer. Onlycountedadvances. The store's internal counter is unchanged.Tests
ruff: clean.pytestrun has 10 failures intest_attempt_processes.pyandtest_control_offline.py. The same 10 fail on a cleanmainon this machine, and they pass on CI (Linux).producer_suitewas still going when this PR was opened, so theproducerjob on this PR is the check for that part.🤖 Generated with Claude Code