fix: load dotenv inside figma-sync main to avoid top-level await - #2016
Open
raskara-LD wants to merge 2 commits into
Open
fix: load dotenv inside figma-sync main to avoid top-level await#2016raskara-LD wants to merge 2 commits into
raskara-LD wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 6c5433e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsxcompilespackages/icons/scripts/figma-sync.tsas CommonJS (the icons package has no"type": "module"), which cannot emit top-levelawait.await import('dotenv')at module scope, so@launchpad-ui/icons:syncfailed in CI withTop-level await is currently not supported with the "cjs" output format.main()instead of using top-levelawait.Screenshots (if appropriate):
N/A
Testing approaches
DRY_RUN=1 pnpm nx run @launchpad-ui/icons:syncshowsMissing FIGMA_ACCESS_TOKENand did not fail during compile time anymore.Note
Overview
Fixes
@launchpad-ui/icons:syncfailing undertsxwhen optional dotenv loading used top-levelawait, which CommonJS output cannot emit for this package.Optional
.envloading is moved intoloadOptionalDotenv(), awaited frommain()before readingFIGMA_ACCESS_TOKEN,DRY_RUN, andFORCE_SYNC. Token validation andprocess.exit(1)run after dotenv so local env files still apply.Adds an empty changeset stub (
.changeset/some-nights-film.md).Reviewed by Cursor Bugbot for commit 6c5433e. Bugbot is set up for automated code reviews on this repo. Configure here.