fix(ws): bound endpoint discovery request timeout - #170
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebSocket reconnect path performs endpoint discovery with
requests.postand no timeout. A stalled connection can block_get_conn_url()indefinitely, preventing subsequent reconnect attempts.Set a 10-second connect timeout and a 30-second read timeout. The existing exception handling in
_try_connect()handles request timeouts and lets the reconnect loop continue.Validation:
python -m pytest lark_oapi/ws/tests/test_websockets_compat.py -q(5 passed) andgit diff --check. The focused test verifies the timeout passed to Requests; no live Feishu or network black-hole test was run.Fixes #169