Repository navigation
Google sign-in: link only verified emails and claim unverified accounts - #24
Merged
Merged
Conversation
loginExternal() links an existing account only when the provider says the email is verified. If the local account itself was never verified, its password is replaced and its sessions revoked before the provider's user signs in. The callback flashes a message when linking is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ZbncuXneGAhsgTaizfjVi
qisthidev
marked this pull request as ready for review
November 7, 2026 04:54
Merged
qisthidev
added a commit
that referenced
this pull request
Nov 7, 2026
- package.json 0.6.1; volt-preline v0.3.1. - docs/UPGRADING.md: what derived apps should port from #23, #24 and #25. Claude-Session: https://claude.ai/code/session_016ZbncuXneGAhsgTaizfjVi Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved by the maintainer (K3, 7 Nov).
AuthService::loginExternal():email_verified, sign-in is refused with "Sign in with your password to use this account". The Google callback shows that as a flash message on the login page.New
UserRepository::markVerified().Tests: no linking without provider verification; an unverified pre-registered account loses its old password and sessions. The existing "creates the account once" test now passes
emailVerified: trueon the second call, which is what Google sends.Checked locally:
npm run typecheck,npm test(39 pass).🤖 Generated with Claude Code
https://claude.ai/code/session_016ZbncuXneGAhsgTaizfjVi